Page MenuHomeFreeBSD

Suppress D_NEEDGIANT warnings for some drivers
ClosedPublic

Authored by markj on Jun 4 2021, 10:12 PM.
Tags
None
Referenced Files
F80093904: D30649.diff
Wed, Mar 27, 8:01 PM
Unknown Object (File)
Sat, Mar 16, 2:08 PM
Unknown Object (File)
Fri, Mar 15, 6:15 PM
Unknown Object (File)
Thu, Mar 7, 3:51 PM
Unknown Object (File)
Jan 31 2024, 12:45 PM
Unknown Object (File)
Jan 26 2024, 7:44 AM
Unknown Object (File)
Jan 14 2024, 4:57 AM
Unknown Object (File)
Dec 20 2023, 2:58 AM
Subscribers

Details

Summary

During boot we warn that the kbd and openfirm drivers are Giant-locked
and may be deleted. Generally, the warning helps signal that certain
old drivers are not being maintained and are subject to removal, but
this doesn't really apply to certain drivers which are harder to
detangle from Giant.

Add a flag, D_GIANTOK, that devices can specify to suppress the
misleading warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jun 4 2021, 10:12 PM
jhb added a subscriber: jhb.

Not sure if there any others for which suppressing the warning makes sense.

This revision is now accepted and ready to land.Jun 4 2021, 10:15 PM
In D30649#688475, @jhb wrote:

Not sure if there any others for which suppressing the warning makes sense.

There is one in the external LinuxKPI which should also be flagged, but obviously that's a separate change. I haven't seen any others in my testing on amd64 and arm64.

While I'd rather we continue to whine about these, The specific ones flagged are OK.
I'm surprised there's one in LinuxKPI :(

This revision was automatically updated to reflect the committed changes.