Suppress D_NEEDGIANT warnings for some drivers
ClosedPublic
Actions

Authored by markj on Jun 4 2021, 10:12 PM.

Details

Reviewers

imp
jhb

Commits

rGfbeb4ccac990: Suppress D_NEEDGIANT warnings for some drivers

Summary

During boot we warn that the kbd and openfirm drivers are Giant-locked
and may be deleted. Generally, the warning helps signal that certain
old drivers are not being maintained and are subject to removal, but
this doesn't really apply to certain drivers which are harder to
detangle from Giant.

Add a flag, D_GIANTOK, that devices can specify to suppress the
misleading warning.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 4 2021, 10:12 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 4 2021, 10:12 PM

markj requested review of this revision.Jun 4 2021, 10:12 PM

Harbormaster completed remote builds in B39720: Diff 90437.Jun 4 2021, 10:12 PM

markj added a reviewer: imp.Jun 4 2021, 10:13 PM

Not sure if there any others for which suppressing the warning makes sense.

This revision is now accepted and ready to land.Jun 4 2021, 10:15 PM

In D30649#688475, @jhb wrote:

Not sure if there any others for which suppressing the warning makes sense.

There is one in the external LinuxKPI which should also be flagged, but obviously that's a separate change. I haven't seen any others in my testing on amd64 and arm64.

While I'd rather we continue to whine about these, The specific ones flagged are OK.
I'm surprised there's one in LinuxKPI :(

Closed by commit rGfbeb4ccac990: Suppress D_NEEDGIANT warnings for some drivers (authored by markj). · Explain WhyJun 6 2021, 8:46 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGfbeb4ccac990: Suppress D_NEEDGIANT warnings for some drivers.