Page MenuHomeFreeBSD

Suppress D_NEEDGIANT warnings for some drivers
ClosedPublic

Authored by markj on Fri, Jun 4, 10:12 PM.

Details

Summary

During boot we warn that the kbd and openfirm drivers are Giant-locked
and may be deleted. Generally, the warning helps signal that certain
old drivers are not being maintained and are subject to removal, but
this doesn't really apply to certain drivers which are harder to
detangle from Giant.

Add a flag, D_GIANTOK, that devices can specify to suppress the
misleading warning.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.Fri, Jun 4, 10:12 PM
jhb added a subscriber: jhb.

Not sure if there any others for which suppressing the warning makes sense.

This revision is now accepted and ready to land.Fri, Jun 4, 10:15 PM
In D30649#688475, @jhb wrote:

Not sure if there any others for which suppressing the warning makes sense.

There is one in the external LinuxKPI which should also be flagged, but obviously that's a separate change. I haven't seen any others in my testing on amd64 and arm64.

While I'd rather we continue to whine about these, The specific ones flagged are OK.
I'm surprised there's one in LinuxKPI :(