LinuxKPI: firmware name compat

[bz]

Summary

"Flatten" more latters found in places where names are derived from
device tree files. This is needed by some wireless drivers.

MFC after: 10 days

[emaste]

Out of curiosity do we need to check after each iteration of flattening, or can we just flatten all first (via e.g. strpbrk if in libkern?)

The nesting for additional characters ("/", ",", ".", ...) seems odd, perhaps this could benefit from a bit broader rework

sys/compat/linuxkpi/common/src/linux_firmware.c

90–91

Also need to change this?

[bz]

In D30640#688418, @emaste wrote:

Out of curiosity do we need to check after each iteration of flattening, or can we just flatten all first (via e.g. strpbrk if in libkern?)

Yeah, I was wondering about that too; I need to do a full analysis of how we create various firmware images again to see what needs to be checked individually and what we can make a "policy" you do it all.

Let's keep this here and I'll do the due diligens when I have a few minutes and write things up as well into something like a man page or wiki or just a README... with samples how to build the module Makefiles.
And then I'll probably find that between the 4 drivers I tried I can even make some of Makefile.inc more generalized into sys/conf/

sys/compat/linuxkpi/common/src/linux_firmware.c

90–91

Probably. I assume I didn't notice given they all have / as well in first place.

[bz]

@bz https://cgit.FreeBSD.org/src/commit/?id=628a4156a761d3daac8a4adc0e675c6e6064fd5a

[bz]

Can someone please request changes on the review for @emaste 's comments and the newly added '@' (in the base system). Seems I cannot do that myself in Phab :(

[bz]

Going to look into this next week to clear out more open reviews of mine...