Page MenuHomeFreeBSD

LinuxKPI: firmware name compat
AcceptedPublic

Authored by bz on Fri, Jun 4, 5:17 PM.

Details

Reviewers
hselasky
Group Reviewers
linuxkpi
Summary

"Flatten" more latters found in places where names are derived from
device tree files. This is needed by some wireless drivers.

MFC after: 10 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 39708
Build 36597: arc lint + arc unit

Event Timeline

bz requested review of this revision.Fri, Jun 4, 5:17 PM

Out of curiosity do we need to check after each iteration of flattening, or can we just flatten all first (via e.g. strpbrk if in libkern?)

The nesting for additional characters ("/", ",", ".", ...) seems odd, perhaps this could benefit from a bit broader rework

sys/compat/linuxkpi/common/src/linux_firmware.c
90–91

Also need to change this?

This revision is now accepted and ready to land.Fri, Jun 4, 9:04 PM

Out of curiosity do we need to check after each iteration of flattening, or can we just flatten all first (via e.g. strpbrk if in libkern?)

Yeah, I was wondering about that too; I need to do a full analysis of how we create various firmware images again to see what needs to be checked individually and what we can make a "policy" you do it all.

Let's keep this here and I'll do the due diligens when I have a few minutes and write things up as well into something like a man page or wiki or just a README... with samples how to build the module Makefiles.
And then I'll probably find that between the 4 drivers I tried I can even make some of Makefile.inc more generalized into sys/conf/

sys/compat/linuxkpi/common/src/linux_firmware.c
90–91

Probably. I assume I didn't notice given they all have / as well in first place.