Append also flavored COMMENT, in order to make it consistent with
other variables.
Details
Details
- Reviewers
- None
- Group Reviewers
portmgr
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 39637 Build 36526: arc lint + arc unit
Event Timeline
Comment Actions
I don't like it, FLAVORS are just changing the way something is built, it is not going to change what the software is.
If you really think your port absolutely needs to change what it is supposed to be, there are a handful of ports that already change their COMMENT according to FLAVORS, look at devel/binutils or devel/git.
Comment Actions
Is this not missing the point? git, binutils, emacs, mg are changing COMMENT because the port is built with a different feature set and it is the first thing users see when they run pkg search. It helps disambiguate the packages beyond just the package names.
It's about
git-2.31.1_1 Distributed source code management tool git-gui-2.31.1_1 Distributed source code management tool git-lite-2.31.1_1 Distributed source code management tool git-svn-2.31.1_1 Distributed source code management tool git-tiny-2.31.1_1 Distributed source code management tool mg-6.8.1,1 Small, fast Emacs-like editor mg-static-6.8.1,1 Small, fast Emacs-like editor
vs
git-2.31.1_1 Distributed source code management tool git-gui-2.31.1_1 Distributed source code management tool (GUI enabled flavor) git-lite-2.31.1_1 Distributed source code management tool (lite flavor) git-svn-2.31.1_1 Distributed source code management tool (SVN enabled flavor) git-tiny-2.31.1_1 Distributed source code management tool (tiny flavor) mg-6.8.1,1 Small, fast Emacs-like editor mg-static-6.8.1,1 Small, fast Emacs-like editor (rescue(8) version)
EDIT: In case it wasn't obvious, I'm in favor of adding this helper.