Page MenuHomeFreeBSD

Mk/bsd.port.mk: Append also flavored COMMENT
AbandonedPublic

Authored by otis on Jun 1 2021, 11:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 6:34 PM
Unknown Object (File)
Sat, Oct 19, 5:13 PM
Unknown Object (File)
Sat, Oct 19, 3:30 PM
Unknown Object (File)
Wed, Oct 9, 8:51 AM
Unknown Object (File)
Oct 6 2024, 7:42 AM
Unknown Object (File)
Oct 4 2024, 3:45 AM
Unknown Object (File)
Oct 3 2024, 10:18 AM
Unknown Object (File)
Sep 30 2024, 9:08 AM

Details

Reviewers
None
Group Reviewers
portmgr
Summary

Append also flavored COMMENT, in order to make it consistent with
other variables.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 39637
Build 36526: arc lint + arc unit

Event Timeline

otis requested review of this revision.Jun 1 2021, 11:00 AM

I don't like it, FLAVORS are just changing the way something is built, it is not going to change what the software is.

If you really think your port absolutely needs to change what it is supposed to be, there are a handful of ports that already change their COMMENT according to FLAVORS, look at devel/binutils or devel/git.

In D30592#687089, @mat wrote:

I don't like it, FLAVORS are just changing the way something is built, it is not going to change what the software is.

If you really think your port absolutely needs to change what it is supposed to be, there are a handful of ports that already change their COMMENT according to FLAVORS, look at devel/binutils or devel/git.

Is this not missing the point? git, binutils, emacs, mg are changing COMMENT because the port is built with a different feature set and it is the first thing users see when they run pkg search. It helps disambiguate the packages beyond just the package names.

It's about

git-2.31.1_1                   Distributed source code management tool
git-gui-2.31.1_1               Distributed source code management tool
git-lite-2.31.1_1              Distributed source code management tool
git-svn-2.31.1_1               Distributed source code management tool
git-tiny-2.31.1_1              Distributed source code management tool
mg-6.8.1,1                     Small, fast Emacs-like editor
mg-static-6.8.1,1              Small, fast Emacs-like editor

vs

git-2.31.1_1                   Distributed source code management tool
git-gui-2.31.1_1               Distributed source code management tool (GUI enabled flavor)
git-lite-2.31.1_1              Distributed source code management tool (lite flavor)
git-svn-2.31.1_1               Distributed source code management tool (SVN enabled flavor)
git-tiny-2.31.1_1              Distributed source code management tool (tiny flavor)
mg-6.8.1,1                     Small, fast Emacs-like editor
mg-static-6.8.1,1              Small, fast Emacs-like editor (rescue(8) version)

EDIT: In case it wasn't obvious, I'm in favor of adding this helper.