Page MenuHomeFreeBSD
Differential D30552

tmpfs: avoid the vm object lock in tmpfs_pager_getvp in the common case
AbandonedPublic
Actions

Authored by mjg on May 30 2021, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 3:36 AM
Unknown Object (File)
Fri, Nov 28, 10:49 PM
Unknown Object (File)
Sun, Nov 16, 11:30 PM
Unknown Object (File)
Nov 5 2025, 6:53 PM
Unknown Object (File)
Nov 5 2025, 6:53 PM
Unknown Object (File)
Nov 5 2025, 4:51 PM
Unknown Object (File)
Oct 23 2025, 12:24 AM
Unknown Object (File)
Oct 21 2025, 4:55 AM
View All 52 Files
Subscribers
imp

Details

Reviewers
kib
markj
Summary

This saves about 8% of wait time on vm object lock when doing -j 104 incremental kernel-only tinderbox run.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg requested review of this revision.May 30 2021, 3:55 PM
mjg created this revision.
kib added inline comments.May 30 2021, 6:25 PM
sys/fs/tmpfs/tmpfs_subr.c
212

What for is this acquire fence?

247

Either this check is needed in the tmpfs_pager_getvp_smp(), or it is not needed there.

In fact, I am not sure that we clean up enough of the un_pager to guarantee that swp_tmpfs is always NULL for newly allocated object, so I think that OBJT_SWAP check is still needed.

mjg abandoned this revision.Mar 12 2024, 10:33 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 12 2024, 10:33 PM

Revision Contents
Changeset List

PathSize
sys/
fs/
tmpfs/
53 lines

Diff 90128

View Options

sys/fs/tmpfs/tmpfs_subr.c

Loading...