Fix iSCSI hangs on shutdown.
ClosedPublic
Actions

Authored by trasz on Jul 11 2015, 3:07 PM.

Details

Reviewers

Commits

rS286226: Rework the way iSCSI initiator handles system shutdown. This fixes

Summary

Rework the way iSCSI initiator handles system shutdown. This fixes
hangs on shutdown with mounted LUNs from a reconnecting session.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

trasz updated this revision to Diff 6858.Jul 11 2015, 3:07 PM

trasz retitled this revision from to Fix iSCSI hangs on shutdown..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptJul 11 2015, 3:07 PM

trasz added a reviewer: mav.Jul 11 2015, 3:08 PM

While I agree with not trying to reconnect on shutdown, that predictable fail due to absence of iscsid, I am not sure what is the motivation of other changes. For example, destroying device before the final sync may leave FS dirty. Is there some problem to keep connection active until both FS and CAM do their syncs?

Erm, but that's exactly what this patch does - or at least it's supposed to do: working sessions continue to work as before, while disconnected ones fail IO instead of waiting for reconnection.

Closed by commit rS286226: Rework the way iSCSI initiator handles system shutdown. This fixes (authored by trasz). · Explain WhyAug 3 2015, 11:57 AM

This revision was automatically updated to reflect the committed changes.

smh mentioned this in D4429: Close iSCSI sessions on shutdown.Dec 7 2015, 3:06 PM

smh mentioned this in rS293659: Close iSCSI sessions on shutdown.Jan 11 2016, 10:24 AM