Page MenuHomeFreeBSD

LinuxKPI: add irq_set_affinity_hint()
ClosedPublic

Authored by bz on May 24 2021, 6:28 PM.

Details

Summary

Add an implementation for irq_set_affinity_hint() to linux/interrupt.h
and include linux/hardirq.h for synchronize_irq() as needed by
wireless drivers.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Reviewed by:
Differential Revision:

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz requested review of this revision.May 24 2021, 6:28 PM
hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/interrupt.h
201

Synchronize IRQ is already defined here:
sys/compat/linuxkpi/common/include/linux/hardirq.h:#define synchronize_irq(irq) _intr_drain((irq))

Please resolve!

sys/compat/linuxkpi/common/include/linux/interrupt.h
44

This is also defined in irqreturn but differently. Sigh.

201

Seems we can just include linux/hardirq.h here.

Include hardirq.h instead of synchronize_irq().

bz marked an inline comment as done.May 25 2021, 8:25 AM
bz retitled this revision from LinuxKPI: add irq_set_affinity_hint() and synchronize_irq() to LinuxKPI: add irq_set_affinity_hint().May 25 2021, 8:35 AM
bz edited the summary of this revision. (Show Details)

Can you have a look at this updated version as well please?

s/__inline/inline

Else looks good.

This revision is now accepted and ready to land.May 25 2021, 11:30 AM
This revision was automatically updated to reflect the committed changes.