Page MenuHomeFreeBSD

linuxcommon: retire extra module version.
ClosedPublic

Authored by dchagin on May 23 2021, 9:54 PM.

Details

Summary

The second 'linuxcommon' line was added by r349886
(c66f5b079d2a259c3a65b1efe0f2143cd030dc52) but Linuxulator's modules
dependend on 'linux_common'. To avoid such mistakes in the future
make all modules dependent on 'linuxcommon'.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rename module to linuxcommon

sys/compat/linux/linux_common.c
88–89

I'm a little confused, were there other references to linuxcommon already, or other reasons linuxcommon is preferable to linux_common?

Could we not instead just change this to DECLARE_MODULE(linux_common, linux_common_mod, SI_SUB_EXEC, SI_ORDER_ANY); and move the MODULE_VERSION(linux_common, 1); here?

sure, rename moduledata name and module name to 'linux_common' and retire 'linuxcommon' line.

This revision is now accepted and ready to land.May 25 2021, 6:20 PM
This revision was automatically updated to reflect the committed changes.