Differential D30383

cam: remove sim callout
ClosedPublic
Actions

Authored by imp on May 21 2021, 3:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 4 2024, 7:36 AM

	Unknown Object (File)
	Jan 14 2024, 5:04 AM

	Unknown Object (File)
	Jan 12 2024, 2:37 AM

	Unknown Object (File)
	Dec 23 2023, 12:36 AM

	Unknown Object (File)
	Dec 17 2023, 5:06 AM

	Unknown Object (File)
	Nov 21 2023, 11:35 AM

	Unknown Object (File)
	Oct 18 2023, 12:35 AM

	Unknown Object (File)
	Sep 26 2023, 6:39 AM

View All 20 Files

Subscribers

None

Details

Reviewers

scottl
ken
mav

Group Reviewers

Commits

rG28027f28e607: cam: remove sim callout

Summary

Nothing is using the sim callout to unfreeze the queue. Remove it to
simplify the SIM.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.May 21 2021, 3:22 PM

Herald added a reviewer: cam. · View Herald TranscriptMay 21 2021, 3:22 PM

imp requested review of this revision.May 21 2021, 3:22 PM

Harbormaster completed remote builds in B39339: Diff 89600.May 21 2021, 3:22 PM

imp added reviewers: scottl, ken, mav.May 21 2021, 3:24 PM

imp added inline comments.

sys/cam/cam_sim.h
104–105	I know flags is now unused after this change, but I'm about to use it for other reasons which is why I noticed this feature was unused.

imp added inline comments.May 21 2021, 3:47 PM

sys/cam/cam_sim.h
105	This was introduced by Justin in the initial CAM commit. It was used to freeze the queue on a bus reset. Now we just note the time of the reset. It's not been set in the CAM code since sometime before stable/3 (the oldest tree I have around). It looks like it was removed in 1999 when Justin re-did the bug reset logic. 6d039cdb75977fabc63ee268a96c990f08ea68ed has the MFC to stable/3, though I've not trolled to see where it changed on main yet given how old it is.

R10:87cfaf0e1fbd38cf7f9843ec462b5401e914f4d1 is the commit in main that removed setting this flag.

Also, the free code doesn't cancel the callout and there's no locking around it at all to keep multiple threads from frobbing it.

scottl accepted this revision.May 21 2021, 7:30 PM

This revision is now accepted and ready to land.May 21 2021, 7:30 PM

mav accepted this revision.May 21 2021, 8:32 PM

Closed by commit rG28027f28e607: cam: remove sim callout (authored by imp). · Explain WhyMay 25 2021, 3:20 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG28027f28e607: cam: remove sim callout.

Revision Contents
Changeset List

Path

Size

sys/

cam/

2 lines

1 line

9 lines

Diff 89819

sys/cam/cam_sim.h

Loading...

sys/cam/cam_sim.c

Loading...

sys/cam/cam_xpt.c

Loading...