Page MenuHomeFreeBSD
Differential D30352

cam: introduce xpt_setup_stack_ccb
Needs ReviewPublic
Actions

Authored by imp on May 20 2021, 2:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 8:46 AM
Unknown Object (File)
Wed, Apr 10, 4:10 AM
Unknown Object (File)
Wed, Apr 10, 4:08 AM
Unknown Object (File)
Wed, Apr 10, 4:08 AM
Unknown Object (File)
Wed, Apr 10, 4:08 AM
Unknown Object (File)
Wed, Apr 10, 4:08 AM
Unknown Object (File)
Wed, Apr 10, 4:07 AM
Unknown Object (File)
Wed, Apr 10, 2:46 AM
View All 23 Files
Subscribers
dab
jhibbits

Details

Reviewers
trasz
slm
Group Reviewers
cam
Summary

Create a new function xpt_setup_stack_ccb which is used to setup a ccb
that lives on the stack.

Sponsored by: Netflix

Test Plan

This is a thought experiment on how one might create a safer version of this that we could assert on later.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39316
Build 36205: arc lint + arc unit

Event Timeline

imp created this revision.May 20 2021, 2:15 AM
Herald added a reviewer: cam. · View Herald TranscriptMay 20 2021, 2:15 AM
imp requested review of this revision.May 20 2021, 2:15 AM
Harbormaster completed remote builds in B39296: Diff 89494.May 20 2021, 2:15 AM
imp mentioned this in D30300: pms(4): clear CCBs allocated on the stack.May 20 2021, 2:16 AM
imp edited the test plan for this revision. (Show Details)
imp added a reviewer: trasz.
imp updated this revision to Diff 89495.May 20 2021, 2:21 AM
imp edited the test plan for this revision. (Show Details)

Add malloc tagging and add assert to xpt_setup_ccb

Harbormaster completed remote builds in B39297: Diff 89495.May 20 2021, 2:21 AM
imp added a comment.May 20 2021, 2:22 AM

Note: this just does scsi_da.c as a proof of concept, but doesn't go through the tree yet.

imp added a comment.May 20 2021, 5:01 AM
This comment was removed by imp.
imp added a comment.May 20 2021, 5:10 AM

https://reviews.freebsd.org/D30353 has all the other changes, and a good coccinelle script for spatch

imp updated this revision to Diff 89499.May 20 2021, 5:52 AM

tweak the script to eliminate a couple of bugs

Herald added a reviewer: slm. · View Herald TranscriptMay 20 2021, 5:52 AM
Herald added subscribers: dab, jhibbits. · View Herald Transcript
Harbormaster completed remote builds in B39301: Diff 89499.May 20 2021, 5:52 AM
imp updated this revision to Diff 89501.May 20 2021, 5:59 AM

better script

Harbormaster completed remote builds in B39302: Diff 89501.May 20 2021, 5:59 AM
imp updated this revision to Diff 89503.May 20 2021, 6:04 AM

oops, regen with right patch

Harbormaster completed remote builds in B39303: Diff 89503.May 20 2021, 6:04 AM
imp updated this revision to Diff 89546.May 20 2021, 5:17 PM

assert we're not freeing a stack thing
Get the names of the field right

Harbormaster completed remote builds in B39316: Diff 89546.May 20 2021, 5:18 PM

Revision Contents
Changeset List

PathSize
sys/
cam/
3 lines
4 lines
19 lines
scsi/
24 lines

Diff 89546

View Options

sys/cam/cam_ccb.h

Loading...
View Options

sys/cam/cam_xpt.h

Loading...
View Options

sys/cam/cam_xpt.c

Loading...
View Options

sys/cam/scsi/scsi_da.c

Loading...