ums(4): Do not stop USB xfers on FIFO close when evdev is still active
ClosedPublic
Actions

Authored by wulf on May 18 2021, 10:57 PM.

Details

Reviewers

Commits

rG8696dd92ffb7: ums(4): Do not stop USB xfers on FIFO close when evdev is still active
rGa4a738ba7575: ums(4): Do not stop USB xfers on FIFO close when evdev is still active
rG05ab03a31798: ums(4): Do not stop USB xfers on FIFO close when evdev is still active

Summary

This fixes lose of evdev events after moused has been killed.

While here use bitwise operations for UMS_EVDEV_OPENED flag.

Test Plan

Kill moused attached to /dev/ums while a evdev consumer is attached to corresponding input/event device node. Than ensure that evdev events are still produced.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.May 18 2021, 10:57 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMay 18 2021, 10:57 PM

wulf requested review of this revision.May 18 2021, 10:57 PM

Harbormaster completed remote builds in B39284: Diff 89456.May 18 2021, 10:57 PM

While here use bitwise operations for UMS_EVDEV_OPENED flag.

Harbormaster completed remote builds in B39285: Diff 89457.May 18 2021, 11:19 PM

wulf edited the summary of this revision. (Show Details)May 18 2021, 11:22 PM

wulf edited the test plan for this revision. (Show Details)

wulf added a reviewer: • hselasky.

• hselasky accepted this revision.May 19 2021, 7:32 AM

This revision is now accepted and ready to land.May 19 2021, 7:32 AM

• hselasky added inline comments.May 19 2021, 7:35 AM

sys/dev/usb/input/ums.c
951	This code must be under: #ifdef XXX
968	This code must be under #ifdef XXX

wulf marked 2 inline comments as done.May 19 2021, 7:47 AM

wulf added inline comments.

sys/dev/usb/input/ums.c
951	This code must be under: #ifdef XXX It already is. See line 943

Good!

Closed by commit rG05ab03a31798: ums(4): Do not stop USB xfers on FIFO close when evdev is still active (authored by wulf). · Explain WhyMay 23 2021, 10:44 PM

This revision was automatically updated to reflect the committed changes.

wulf marked an inline comment as done.

wulf added a commit: rG05ab03a31798: ums(4): Do not stop USB xfers on FIFO close when evdev is still active.

wulf added a commit: rGa4a738ba7575: ums(4): Do not stop USB xfers on FIFO close when evdev is still active.Jun 13 2021, 10:03 PM

wulf added a commit: rG8696dd92ffb7: ums(4): Do not stop USB xfers on FIFO close when evdev is still active.Jun 13 2021, 10:08 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

input/

ums.c

13 lines

Diff 89704

View Options

ums(4): Do not stop USB xfers on FIFO close when evdev is still activeClosedPublicActions