Page MenuHomeFreeBSD

ums(4): Do not stop USB xfers on FIFO close when evdev is still active
ClosedPublic

Authored by wulf on May 18 2021, 10:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 2:38 PM
Unknown Object (File)
Feb 17 2024, 1:48 PM
Unknown Object (File)
Jan 20 2024, 11:31 AM
Unknown Object (File)
Dec 25 2023, 1:36 AM
Unknown Object (File)
Dec 22 2023, 2:54 PM
Unknown Object (File)
Dec 20 2023, 2:19 AM
Unknown Object (File)
Dec 14 2023, 10:14 PM
Unknown Object (File)
Nov 22 2023, 9:00 PM

Details

Summary

This fixes lose of evdev events after moused has been killed.

While here use bitwise operations for UMS_EVDEV_OPENED flag.

Test Plan

Kill moused attached to /dev/ums while a evdev consumer is attached to corresponding input/event device node. Than ensure that evdev events are still produced.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39284
Build 36173: arc lint + arc unit

Event Timeline

wulf requested review of this revision.May 18 2021, 10:57 PM

While here use bitwise operations for UMS_EVDEV_OPENED flag.

wulf edited the test plan for this revision. (Show Details)
wulf added a reviewer: hselasky.
This revision is now accepted and ready to land.May 19 2021, 7:32 AM
sys/dev/usb/input/ums.c
951

This code must be under:

#ifdef XXX
968

This code must be under

#ifdef XXX
wulf marked 2 inline comments as done.May 19 2021, 7:47 AM
wulf added inline comments.
sys/dev/usb/input/ums.c
951

This code must be under:

#ifdef XXX

It already is. See line 943

This revision was automatically updated to reflect the committed changes.
wulf marked an inline comment as done.