Page MenuHomeFreeBSD

ums(4): Do not stop USB xfers on FIFO close when evdev is still active
ClosedPublic

Authored by wulf on May 18 2021, 10:57 PM.

Details

Summary

This fixes lose of evdev events after moused has been killed.

While here use bitwise operations for UMS_EVDEV_OPENED flag.

Test Plan

Kill moused attached to /dev/ums while a evdev consumer is attached to corresponding input/event device node. Than ensure that evdev events are still produced.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wulf requested review of this revision.May 18 2021, 10:57 PM

While here use bitwise operations for UMS_EVDEV_OPENED flag.

wulf edited the test plan for this revision. (Show Details)
wulf added a reviewer: hselasky.
This revision is now accepted and ready to land.May 19 2021, 7:32 AM
sys/dev/usb/input/ums.c
951

This code must be under:

#ifdef XXX
968

This code must be under

#ifdef XXX
wulf marked 2 inline comments as done.May 19 2021, 7:47 AM
wulf added inline comments.
sys/dev/usb/input/ums.c
951

This code must be under:

#ifdef XXX

It already is. See line 943

This revision was automatically updated to reflect the committed changes.
wulf marked an inline comment as done.