dummynet: Remove unused code
ClosedPublic
Actions

Authored by kp on May 17 2021, 1:44 PM.

Details

Reviewers

Commits

rGa1e6442cbf36: dummynet: Remove unused code
rG137c43e13edb: dummynet: Remove unused code
rG02c44f40f984: dummynet: Remove unused code

Summary

We never set 'busy' and never dequeue from the pending mq. Remove this
code.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.May 17 2021, 1:44 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptMay 17 2021, 1:44 PM

kp requested review of this revision.May 17 2021, 1:44 PM

Harbormaster completed remote builds in B39244: Diff 89350.May 17 2021, 1:44 PM

Just want to note, I'm sorry for long delay, I moved temporary to another project and dummynet overhaul is not done yet. But I plan to publish the code somewhere on guthub.

This revision is now accepted and ready to land.May 17 2021, 2:32 PM

Closed by commit rG02c44f40f984: dummynet: Remove unused code (authored by kp). · Explain WhyMay 17 2021, 3:05 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG02c44f40f984: dummynet: Remove unused code.

In D30313#680789, @ae wrote:

Just want to note, I'm sorry for long delay, I moved temporary to another project and dummynet overhaul is not done yet. But I plan to publish the code somewhere on guthub.

That'd be useful, yes, even if it's not in a working - or even compiling - state right now.

My immediate interest is in the bits of that work to move dummynet configuration into a separate utility, because that's a requirement for dummynet-in-pf. The rest of it is valuable as well, but more of a long term interest.

kp added a commit: rG137c43e13edb: dummynet: Remove unused code.May 24 2021, 3:42 PM

kp added a commit: rGa1e6442cbf36: dummynet: Remove unused code.