Page MenuHomeFreeBSD

dummynet: Remove unused code
ClosedPublic

Authored by kp on May 17 2021, 1:44 PM.

Details

Summary

We never set 'busy' and never dequeue from the pending mq. Remove this
code.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.May 17 2021, 1:44 PM

Just want to note, I'm sorry for long delay, I moved temporary to another project and dummynet overhaul is not done yet. But I plan to publish the code somewhere on guthub.

This revision is now accepted and ready to land.May 17 2021, 2:32 PM
This revision was automatically updated to reflect the committed changes.
In D30313#680789, @ae wrote:

Just want to note, I'm sorry for long delay, I moved temporary to another project and dummynet overhaul is not done yet. But I plan to publish the code somewhere on guthub.

That'd be useful, yes, even if it's not in a working - or even compiling - state right now.

My immediate interest is in the bits of that work to move dummynet configuration into a separate utility, because that's a requirement for dummynet-in-pf. The rest of it is valuable as well, but more of a long term interest.