Page MenuHomeFreeBSD

linux: Fix SMAP-enabled futex routines
ClosedPublic

Authored by markj on May 15 2021, 3:29 PM.

Details

Summary

Some of them were dereferencing the user pointer before disabling SMAP.

PR: 255591
Tested by: pitwuu@gmail.com

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.May 15 2021, 3:29 PM

It is indeed weird, because cb0eecdf927 was reported by relatively many people, and you can see testers.

This revision is now accepted and ready to land.May 15 2021, 7:21 PM
In D30276#680193, @kib wrote:

It is indeed weird, because cb0eecdf927 was reported by relatively many people, and you can see testers.

Some of the ops did not have this bug, so I guess only those ops were being used before. The reporter of PR 255591 also claimed that the panic does not occur on 13.0, which is also strange.

This revision was automatically updated to reflect the committed changes.