linux: Fix SMAP-enabled futex routines
ClosedPublic
Actions

Authored by markj on May 15 2021, 3:29 PM.

Details

Reviewers

trasz
kib

Commits

rGfb580451456a: linux: Fix SMAP-enabled futex routines

Summary

Some of them were dereferencing the user pointer before disabling SMAP.

PR: 255591
Tested by: pitwuu@gmail.com

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 15 2021, 3:29 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 15 2021, 3:29 PM

markj requested review of this revision.May 15 2021, 3:29 PM

Harbormaster completed remote builds in B39205: Diff 89264.May 15 2021, 3:29 PM

It is indeed weird, because cb0eecdf927 was reported by relatively many people, and you can see testers.

This revision is now accepted and ready to land.May 15 2021, 7:21 PM

In D30276#680193, @kib wrote:

It is indeed weird, because cb0eecdf927 was reported by relatively many people, and you can see testers.

Some of the ops did not have this bug, so I guess only those ops were being used before. The reporter of PR 255591 also claimed that the panic does not occur on 13.0, which is also strange.

Closed by commit rGfb580451456a: linux: Fix SMAP-enabled futex routines (authored by markj). · Explain WhyMay 16 2021, 5:44 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGfb580451456a: linux: Fix SMAP-enabled futex routines.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

linux/

linux_support.s

12 lines

linux32/

linux32_support.s

12 lines

Diff 89305

View Options

sys/amd64/linux/linux_support.s