Page MenuHomeFreeBSD

ip_output normalization and fixes
ClosedPublic

Authored by eri on Jul 8 2015, 3:37 PM.
Referenced Files
Unknown Object (File)
Thu, May 9, 9:47 AM
Unknown Object (File)
Thu, May 9, 2:54 AM
Unknown Object (File)
Wed, May 8, 10:35 AM
Unknown Object (File)
Mon, May 6, 7:45 AM
Unknown Object (File)
Fri, Apr 26, 6:38 AM
Unknown Object (File)
Fri, Apr 26, 6:23 AM
Unknown Object (File)
Thu, Apr 25, 3:33 AM
Unknown Object (File)
Tue, Apr 16, 4:04 PM
Subscribers

Details

Summary

ip_output has a big chunk of code used to handle special cases with pfil consumers which also forces a reloop on it.
Gather all this code together to make it readable and properly handle the reloop cases.

Some of the issues identified:

  • M_IP_NEXTHOP is not handled properly in existing code.
  • route reference leaking is possible with in FIB number change
  • route flags checking is not consistent in the function

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

eri retitled this revision from to ip_output normalization and fixes.
eri updated this object.
eri edited the test plan for this revision. (Show Details)
eri added a reviewer: gnn.
eri set the repository for this revision to rS FreeBSD src repository - subversion.
eri added a project: network.
eri added a subscriber: network.
gnn edited edge metadata.

Approved.

This revision is now accepted and ready to land.Jul 27 2015, 3:12 PM
This revision was automatically updated to reflect the committed changes.

Do you plan to make similar change for IPv6?

Yea Andrey will do for IPv6.