Page MenuHomeFreeBSD

ip_output normalization and fixes
ClosedPublic

Authored by eri on Jul 8 2015, 3:37 PM.
Referenced Files
F108606380: D3022.id6778.diff
Sun, Jan 26, 8:17 PM
F108567979: D3022.id7477.diff
Sun, Jan 26, 10:50 AM
Unknown Object (File)
Mon, Jan 13, 7:17 AM
Unknown Object (File)
Sun, Jan 12, 4:35 PM
Unknown Object (File)
Thu, Jan 9, 3:46 PM
Unknown Object (File)
Dec 25 2024, 10:58 PM
Unknown Object (File)
Nov 28 2024, 8:49 PM
Unknown Object (File)
Nov 28 2024, 8:05 PM
Subscribers

Details

Summary

ip_output has a big chunk of code used to handle special cases with pfil consumers which also forces a reloop on it.
Gather all this code together to make it readable and properly handle the reloop cases.

Some of the issues identified:

  • M_IP_NEXTHOP is not handled properly in existing code.
  • route reference leaking is possible with in FIB number change
  • route flags checking is not consistent in the function

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

eri retitled this revision from to ip_output normalization and fixes.
eri updated this object.
eri edited the test plan for this revision. (Show Details)
eri added a reviewer: gnn.
eri set the repository for this revision to rS FreeBSD src repository - subversion.
eri added a project: network.
eri added a subscriber: network.
gnn edited edge metadata.

Approved.

This revision is now accepted and ready to land.Jul 27 2015, 3:12 PM
This revision was automatically updated to reflect the committed changes.

Do you plan to make similar change for IPv6?

Yea Andrey will do for IPv6.