Page MenuHomeFreeBSD

net/scapy: Silence warnings
AbandonedPublic

Authored by kp on May 11 2021, 1:37 PM.

Details

Reviewers
None
Summary

These warnings are new (or new to manifest) in 2.4.5 and interfere with
the several FreeBSD regression tests (e.g. pf, bridge, netinet6, ..)

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 39123
Build 36012: arc lint + arc unit

Event Timeline

kp requested review of this revision.May 11 2021, 1:37 PM

Suppress one more warning

I don't fully understand where the problem is - in the scapy code or in the FreeBSD regression tests?

  • If the former - is there any plan to upstream this? If so - then could this information be added into the patches as the comments?
  • If the latter - should we fix the regression tests instead?

nit: Why comment the code out if it can just be removed by the patch?

I don't fully understand where the problem is - in the scapy code or in the FreeBSD regression tests?

  • If the former - is there any plan to upstream this? If so - then could this information be added into the patches as the comments?
  • If the latter - should we fix the regression tests instead?

We did wind up fixing it in the regression tests.
These warnings did not trigger in previous Scapy versions. Now that they do they caused tests to fail because of unexpected output. (atf_check is a bit sensitive to that).

nit: Why comment the code out if it can just be removed by the patch?

It could be, but this was more of an in-progress patch than a final fix. Given that we've fixed it differently this one should be considered abandoned.