Page MenuHomeFreeBSD

libpmc: remove PMC_MDEP_TABLE logic
ClosedPublic

Authored by mhorne on May 10 2021, 8:14 PM.
Tags
None
Referenced Files
F82628092: D30196.diff
Wed, May 1, 12:39 AM
F82612967: D30196.diff
Tue, Apr 30, 9:20 PM
Unknown Object (File)
Tue, Apr 23, 1:24 AM
Unknown Object (File)
Tue, Apr 9, 7:48 PM
Unknown Object (File)
Sat, Apr 6, 2:21 PM
Unknown Object (File)
Fri, Apr 5, 1:00 PM
Unknown Object (File)
Jan 18 2024, 3:08 AM
Unknown Object (File)
Dec 13 2023, 2:17 PM
Subscribers

Details

Summary

This logic was added for handling some of the complicated relationships
between events and x86 CPU models. Since that logic has been mostly
removed from libpmc(3) in favor of pmu-events, this no longer serves
much of a purpose. Mapping CPU types to event tables is already handled
by the switch statement in pmc_init().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39108
Build 35997: arc lint + arc unit

Event Timeline

So in effect this basically just repeated existing tests that exist elsewhere?

This revision is now accepted and ready to land.May 10 2021, 8:20 PM

So in effect this basically just repeated existing tests that exist elsewhere?

Pretty much. pmc_init() adds only supported classes to the pmc_class_table array, so pmc_mdep_is_supported_class() only duplicates work by checking those classes against its own tables.

I like it.
Thanks!

This revision was automatically updated to reflect the committed changes.