Page MenuHomeFreeBSD

Suggest commit title in prepare-commit-msg hook
AbandonedPublic

Authored by grembo on May 7 2021, 11:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 9:42 PM
Unknown Object (File)
Fri, Apr 12, 9:07 PM
Unknown Object (File)
Tue, Apr 9, 6:56 PM
Unknown Object (File)
Thu, Apr 4, 5:10 AM
Unknown Object (File)
Wed, Apr 3, 3:56 PM
Unknown Object (File)
Sat, Mar 30, 5:34 PM
Unknown Object (File)
Dec 20 2023, 2:21 AM
Unknown Object (File)
Dec 19 2023, 11:47 PM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr
Summary

This is done based on the files affected by the commit. Suggests up
to two ports at a time and goes to "many" from there.

Unintrusive, yet helpful to get the commit title right (forgetting
the convention, typos, or committing a port by accident).

IMHO better than creating a draconian commit hook, nudging
committers to do the right thing by making their lives easier.

This is what I use personally, I was asked in private if there
was a chance to get this into the repo, so I wanted to try at
least. No hard feelings if you feel like this is unnecessary.

Test Plan
echo something >>devel/ice/Makefile
echo somethingelse >>editors/joe/Makefile
git commit -a

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 39074
Build 35963: arc lint + arc unit

Event Timeline

Prevent extra empty line when ammending.

Add quoting like in the original template.

Also bring in .arcconfig change from D30162.

Sorry for all the noise, .arcconfig vs. git migration.

@adridg As you've been sending out regular messages about following the commit message conventions. What do you think?

Works for me (with a sample size n=1), having the category/port: already filled in is nice. It demonstrates nicely what is possible.

@mat Next time, please show some basic respect and comment on a review that has been made obsolete by your own contribution (especially since I made it clear that I'm ok if you don't like it).