Page MenuHomeFreeBSD

UDP tunneling issue in rack
ClosedPublic

Authored by rrs on May 7 2021, 8:48 AM.

Details

Summary

Internal testing in NF has found a problem with combining rack and UDP tunneling of TCP.
There is a missing set of additions to the hdrlen to prevent the outbound
mbuf of being to short.

Test Plan

Bring up an image with UDP tunneling and run a rack endpoint and
assure that it actually works.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rrs requested review of this revision.May 7 2021, 8:48 AM
This revision is now accepted and ready to land.May 7 2021, 8:56 AM
tuexen requested changes to this revision.May 7 2021, 1:55 PM

OK, I did some testing using the tcp-over-udp test suite. This patch improves things, but there is at least one more issue... Let me debug this later today.

This revision now requires changes to proceed.May 7 2021, 1:55 PM

Cool lets definitely figure out what is wrong besides what Peter found here

Michael try this with UDP port overbooking as we discussed.

Using this patch, all tests pass now.

This revision is now accepted and ready to land.May 7 2021, 5:45 PM