UDP tunneling issue in rack
ClosedPublic
Actions

Authored by rrs on May 7 2021, 8:48 AM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rGf5d0badc7007: Fix a UDP tunneling issue with rack. Basically there are two
rGa16cee021865: Fix a UDP tunneling issue with rack. Basically there are two

Summary

Internal testing in NF has found a problem with combining rack and UDP tunneling of TCP.
There is a missing set of additions to the hdrlen to prevent the outbound
mbuf of being to short.

Test Plan

Bring up an image with UDP tunneling and run a rack endpoint and
assure that it actually works.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rrs created this revision.May 7 2021, 8:48 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptMay 7 2021, 8:48 AM

Herald added a subscriber: melifaro. · View Herald Transcript

rrs requested review of this revision.May 7 2021, 8:48 AM

tuexen accepted this revision.May 7 2021, 8:56 AM

This revision is now accepted and ready to land.May 7 2021, 8:56 AM

OK, I did some testing using the tcp-over-udp test suite. This patch improves things, but there is at least one more issue... Let me debug this later today.

This revision now requires changes to proceed.May 7 2021, 1:55 PM

Cool lets definitely figure out what is wrong besides what Peter found here

Michael try this with UDP port overbooking as we discussed.

Using this patch, all tests pass now.

This revision is now accepted and ready to land.May 7 2021, 5:45 PM

Closed by commit rGa16cee021865: Fix a UDP tunneling issue with rack. Basically there are two (authored by rrs). · Explain WhyMay 7 2021, 6:12 PM

This revision was automatically updated to reflect the committed changes.

rrs added a commit: rGa16cee021865: Fix a UDP tunneling issue with rack. Basically there are two.

tuexen added a commit: rGf5d0badc7007: Fix a UDP tunneling issue with rack. Basically there are two.Jun 8 2021, 11:59 PM