Page MenuHomeFreeBSD

Updating Virtualization chapter
ClosedPublic

Authored by fel1x.mintchoco.development_gmail.com on May 6 2021, 7:30 AM.

Details

Summary

Deleted Virtual PC because Windows 7 is depreacted now. Updated VMware Fusion part.

PR: 249976

Test Plan

docs and images looks fine

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline


documentation/content/static/imagedocumentation/static/images/books/handbook/virtualization folder with updated VMware fusion related images and deleted Virtual PC images

ygy added a reviewer: docs.
ygy added a reviewer: ygy.

Hi! Before diving into the review, two quick suggestions:

  • It is usually better to submit patches that are generated by diff -U999999 to give better contexts to reviewers.
  • Populating the "Test Plan" section of the reviews is recommended (e.g. doc builds fine, images displayed correctly, etc).
documentation/content/en/books/handbook/virtualization/_index.adoc
152

Are we expecting this to be completed and landed with this review? Otherwise, it might be better to remove this completely and track it by opening another PR in Bugzilla.

159

Same question as above

182

These lines (here and below) seem to miss ":"s at the end


Thank you for your advice. Here is a new full diff file. I corrected :s and deleteed things that are not ready yet(VMware Workstation, Hyper-V).


Thank you for your advice. Here is a new full diff file. I corrected :s and deleteed things that are not ready yet(VMware Workstation, Hyper-V).

Thanks! Could you please use the "update diff" button instead of file upload?

Only found these now. Looking good otherwise.

documentation/content/en/books/handbook/virtualization/_index.adoc
54

s/as on/on/
s/follwing/the following/
s/programs./platforms:/

documentation/content/en/books/handbook/virtualization/_index.adoc
152

I cannot understand what you mean. Do you mean that I should open another PR in Bugzilla to update images?

documentation/content/en/books/handbook/virtualization/_index.adoc
152

This review comment seems shifted since you updated the diff. I was commenting about the "TODO"s which you have already removed, so you may mark this comment as done.

Looks good to me.

This revision is now accepted and ready to land.Jun 12 2021, 3:23 AM

I don't know the system of phabricator, but why the virtualisation part of FreeBSD Handbook did not adopt my patch even my review is accepted? Do I need further tasks to do?

Sorry, this is my fault, I’ll make the commit this night (Spanish time)
Sorry for the delay and thanks for your patch!!

I don't forgot about this. I'm so busy with another patch. I hope to have it finished this weekend and commit this one.
Sorry and thanks for your patience.

I just merged the chapter and it's ok but I don't know why I cannot merge the images.
Can you please share the images with me by email? carlavilla@FreeBSD.org

Sorry for the looooong delay, I was so busy with other review.

I just merged the chapter and it's ok but I don't know why I cannot merge the images.
Can you please share the images with me by email? carlavilla@FreeBSD.org

Sorry for the looooong delay, I was so busy with other review.

I sent a compressed folder with images but forgot to confirm. Did you received my email?

I just merged the chapter and it's ok but I don't know why I cannot merge the images.
Can you please share the images with me by email? carlavilla@FreeBSD.org

Sorry for the looooong delay, I was so busy with other review.

I sent a compressed folder with images but forgot to confirm. Did you received my email?

No, can you please send it to my personal mail? sergio.carlavilla91@gmail.com

I just merged the chapter and it's ok but I don't know why I cannot merge the images.
Can you please share the images with me by email? carlavilla@FreeBSD.org

Sorry for the looooong delay, I was so busy with other review.

I sent a compressed folder with images but forgot to confirm. Did you received my email?

No, can you please send it to my personal mail? sergio.carlavilla91@gmail.com

I sent the compressed image folder.
From fel1x.mintchoco.development@gmail.com to carlavilla@FreeBSD.org via gmail(mail.google.com), including one tar.xz compressed file, at 20:10 GMT-4.