bsnmpd: Return the correct uptime.
ClosedPublic
Actions

Authored by imp on May 5 2021, 12:24 AM.

Details

Reviewers

phk
cy
gnn

Commits

rGf009aedae4d0: bsnmpd: Return the correct uptime.

Summary

Do not assume that the kernel boot time is invariant. It is not. FreeBSD
uses the formula:
wall_time = boot_time + uptime
where uptime is monotinically increasing and boot_time is adjusted to
get the proper time of day. FreeBSD offers a way to retrieve the uptime
directly, so use that instead of trying to compute it by subtracting
boot_time from wall_time.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.May 5 2021, 12:24 AM

imp created this revision.

Harbormaster completed remote builds in B39010: Diff 88628.May 5 2021, 12:24 AM

imp added reviewers: phk, cy, gnn.May 5 2021, 12:25 AM

imp edited the test plan for this revision. (Show Details)

imp retitled this revision from bsndmp: Return the correct uptime. to bsnmpd: Return the correct uptime..May 5 2021, 4:02 AM

This is certainly an improvement over the original.

However tabs have been replaced by spaces (0x20). Is this intentional?

This revision is now accepted and ready to land.May 5 2021, 4:40 AM

In D30114#676001, @cy wrote:

This is certainly an improvement over the original.

However tabs have been replaced by spaces (0x20). Is this intentional?

Nope... not sure how that happened.

Tabs!

This revision now requires review to proceed.May 5 2021, 5:47 AM

Harbormaster completed remote builds in B39017: Diff 88639.May 5 2021, 5:47 AM

cy accepted this revision.May 5 2021, 2:55 PM

This revision is now accepted and ready to land.May 5 2021, 2:55 PM

Closed by commit rGf009aedae4d0: bsnmpd: Return the correct uptime. (authored by imp). · Explain WhyMay 5 2021, 9:14 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGf009aedae4d0: bsnmpd: Return the correct uptime..