Page MenuHomeFreeBSD
Differential D30046

sbin/ipfw: Fix null pointer deference when printing counters
ClosedPublic
Actions

Authored by donner on Apr 30 2021, 2:19 PM.
Tags
None
Referenced Files
F170616661: D30046.id88419.diff
Sat, Sep 5, 4:07 PM
F170553494: D30046.diff
Sat, Sep 5, 9:25 AM
F170487834: D30046.id88507.diff
Sat, Sep 5, 1:41 AM
F170464816: D30046.id.diff
Fri, Sep 4, 11:06 PM
F170430917: D30046.id88507.diff
Fri, Sep 4, 7:22 PM
Unknown Object (File)
Thu, Sep 3, 7:07 PM
Unknown Object (File)
Thu, Sep 3, 7:16 AM
Unknown Object (File)
Thu, Sep 3, 5:56 AM
View All Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
ae
Group Reviewers
network
Commits
rG552885bde600: ^sbin/ipfw: Fix null pointer deference when printing counters
rGb1902474a7c5: sbin/ipfw: Fix null pointer deference when printing counters
rG80b22e631506: sbin/ipfw: Fix null pointer deference when printing counters
rGbf7cc0f9cb66: sbin/ipfw: Fix null pointer deference when printing counters
Summary

ipfw -[tT] prints statistics of the last access. If the rule was never
used, the counter might be not exist. This happens unconditionally on
inserting a new rule. Avoid printing statistics in this case.

PR: 255491
Reported by: Haisheng Zhouz
MFC after: 1 week

Test Plan
# ipfw -t add allow tcp from any to any out

should not segfault.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sbin/
ipfw/
51 lines

Diff 88507

View Options

sbin/ipfw/ipfw2.c

Loading...