Page MenuHomeFreeBSD

sbin/ipfw: Fix null pointer deference when printing counters
ClosedPublic

Authored by donner on Apr 30 2021, 2:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 3:43 PM
Unknown Object (File)
Sun, Oct 12, 5:19 AM
Unknown Object (File)
Sun, Oct 12, 5:19 AM
Unknown Object (File)
Sun, Oct 12, 5:19 AM
Unknown Object (File)
Sat, Oct 11, 7:16 PM
Unknown Object (File)
Sat, Oct 11, 4:07 PM
Unknown Object (File)
Wed, Oct 8, 7:54 AM
Unknown Object (File)
Fri, Oct 3, 10:53 AM

Details

Summary

ipfw -[tT] prints statistics of the last access. If the rule was never
used, the counter might be not exist. This happens unconditionally on
inserting a new rule. Avoid printing statistics in this case.

PR: 255491
Reported by: Haisheng Zhouz
MFC after: 1 week

Test Plan
# ipfw -t add allow tcp from any to any out

should not segfault.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable