Fix a missing initialization in vm_mmap().
ClosedPublic
Actions

Authored by markj on Jul 5 2015, 2:53 AM.

Details

Reviewers

kib
jhb

Commits

rS285180: Add a local variable initialization needed in the OBJT_DEFAULT case.

Summary

object was previously being used uninitialized in the OBJT_DEFAULT case. Looks like this was introduced in r283998.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj updated this revision to Diff 6695.Jul 5 2015, 2:53 AM

markj retitled this revision from to Fix a missing initialization in vm_mmap()..

markj edited the test plan for this revision. (Show Details)

markj updated this object.

Herald added a subscriber: imp. · View Herald TranscriptJul 5 2015, 2:53 AM

markj updated this object.Jul 5 2015, 3:05 AM

markj added reviewers: kib, jhb.

kib accepted this revision.Jul 5 2015, 7:40 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Jul 5 2015, 7:40 AM

Closed by commit rS285180: Add a local variable initialization needed in the OBJT_DEFAULT case. (authored by markj). · Explain WhyJul 5 2015, 10:26 PM

This revision was automatically updated to reflect the committed changes.

This is fine though I probably would have preferred to set object to NULL only in the OBJT_DEFAULT case so it is more explicit as to when that value is used.

In D2992#59332, @jhb wrote:

This is fine though I probably would have preferred to set object to NULL only in the OBJT_DEFAULT case so it is more explicit as to when that value is used.

This could be done separately (the patch is already committed), together with the cleanup of the OBJT_DEVICE case, which is to remove the block and move local vars declaration to the function top level.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_mmap.c

1 line

Diff 6712

View Options

Fix a missing initialization in vm_mmap().ClosedPublicActions