Differential D29736

OCF: Remove support for asymmetric cryptographic operations.
ClosedPublic
Actions

Authored by jhb on Apr 12 2021, 8:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 21, 8:44 PM

	Unknown Object (File)
	Wed, Apr 17, 4:30 AM

	Unknown Object (File)
	Sat, Apr 13, 1:25 AM

	Unknown Object (File)
	Mar 30 2024, 3:57 AM

	Unknown Object (File)
	Mar 30 2024, 3:57 AM

	Unknown Object (File)
	Mar 30 2024, 3:44 AM

	Unknown Object (File)
	Feb 25 2024, 2:34 PM

	Unknown Object (File)
	Jan 12 2024, 9:11 PM

View All 35 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG76681661be28: OCF: Remove support for asymmetric cryptographic operations.

Summary

There haven't been any non-obscure drivers that supported this
functionality and it has been impossible to test to ensure that it
still works. The only known consumer of this interface was the engine
in OpenSSL < 1.1. Modern OpenSSL versions do not include support for
this interface as it was not well-documented.

Sponsored by: Chelsio Communications

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38545
Build 35434: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 12 2021, 8:55 PM

Herald added a reviewer: manpages. · View Herald TranscriptApr 12 2021, 8:55 PM

Herald added subscribers: jmg, imp. · View Herald Transcript

jhb requested review of this revision.Apr 12 2021, 8:55 PM

Harbormaster completed remote builds in B38545: Diff 87343.Apr 12 2021, 8:55 PM

Nice cleanup. I didn't review the man page language updates super thoroughly, but the parts I skimmed looked good.

share/man/man9/Makefile
919	does this last one need an OLD_FILES line?

This revision is now accepted and ready to land.Apr 12 2021, 9:11 PM

cem added inline comments.Apr 12 2021, 9:11 PM

share/man/man9/Makefile
919	... no, I just forgot about it scrolling down. Nevermind.

jhb closed this revision.Apr 12 2021, 9:55 PM

jhb added a commit: rG76681661be28: OCF: Remove support for asymmetric cryptographic operations..

Revision Contents
Changeset List

Path

Size

ObsoleteFiles.inc

7 lines

share/

man/

man4/

143 lines

man9/

5 lines

30 lines

crypto_driver.9

5 lines

sys/

dev/

hifn/

2 lines

safe/

4 lines

mips/

nlm/

dev/

sec/

2 lines

opencrypto/

404 lines

58 lines

248 lines

36 lines

tools/

tools/

crypto/

5 lines

cryptokeytest.c

Diff 87343

ObsoleteFiles.inc

Loading...

share/man/man4/crypto.4

Loading...

share/man/man9/Makefile

Loading...

share/man/man9/crypto.9

Loading...

share/man/man9/crypto_asym.9

Loading...

share/man/man9/crypto_driver.9

Loading...

sys/dev/hifn/hifn7751.c

Loading...

sys/dev/safe/safe.c

Loading...

sys/mips/nlm/dev/sec/nlmsec.c

Loading...

sys/opencrypto/crypto.c

Loading...

sys/opencrypto/cryptodev.h

Loading...

sys/opencrypto/cryptodev.c

Loading...

sys/opencrypto/cryptodev_if.m

Loading...

tools/tools/crypto/Makefile

Loading...

tools/tools/crypto/cryptokeytest.c

Loading...