Page MenuHomeFreeBSD

dns/yadifa: Update to 2.4.2
AbandonedPublic

Authored by otis on Apr 11 2021, 2:45 PM.

Details

Reviewers
osa
swills

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 38500
Build 35389: arc lint + arc unit

Event Timeline

otis requested review of this revision.Apr 11 2021, 2:45 PM
This revision is now accepted and ready to land.Apr 12 2021, 1:29 PM
dns/yadifa/Makefile
19–20

The patch does not introduce any %%USERS%% or %%GROUPS%% (which would both always contain yadifa), so why is the SUB_LIST bit needed?

dns/yadifa/Makefile
19–20

Maintainer did not do proper testing, it seems. My smoke tests showed that it will require more work.

dns/yadifa/Makefile
19–20

You know, as a committer, it can also be your role to fix the few bits that are wrong and commit the fixed version.

otis marked an inline comment as done.Apr 12 2021, 3:06 PM
otis added inline comments.
dns/yadifa/Makefile
19–20

Indeed, by will require more work I meant more work for me.

otis marked an inline comment as done.