Page MenuHomeFreeBSD

[NEW] misc/g810-led: Led controller for Logitech G- Keyboards
AcceptedPublic

Authored by Alexander88207_protonmail.com on Apr 10 2021, 9:01 PM.

Details

Reviewers
koobs
Group Reviewers
Contributor Reviewers (ports)
Summary
[NEW] misc/g810-led: LED controller for Logitech G- Keyboards

Led controller for Logitech G- Keyboards

WWW: https://github.com/MatMoul/g810-led

PR: 254967
Test Plan

Tested by: Andreas Artz on FreeBSD 13 with Logitch G213

g810-led --list-keyboards

Device: Logitech - Gaming Keyboard G213
  Vendor ID: 046d
  Product ID: c336
  Serial Number: 178139583932

Poudriere: Builds OK on FreeBSD 12.2-Release & FreeBSD 13RC5 (with a harmless warning) (Warning: Bad symlink '/usr/local/bin/g413-led' pointing to an absolute pathname '/usr/local/bin/g810-led')

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Alexander88207_protonmail.com retitled this revision from New Port: misc/g810-led to New Port: misc/g810-led: Led controller for Logitech G- Keyboards.Apr 10 2021, 9:09 PM
lwhsu added inline comments.
misc/g810-led/files/patch-makefile.patch
1 ↗(On Diff #87233)

This patch seems doing renaming. Is it possible to do this in post-extract phase?

diizzy added inline comments.
misc/g810-led/Makefile
9

G- Keyboards --> G-series keyboards

15

Should be LIB_DEPENDS+=

15

Err, LIB_DEPENDS=
Sorry

18

This should be yes or did you test all versions?
I assume that it fails using clang

misc/g810-led/pkg-descr
1

Same as above

Alexander88207_protonmail.com marked 6 inline comments as done.

I thank you both for looking over it.

misc/g810-led/Makefile
23–24

And then rename the patch.

I already had a feeling that there is a function for that situation, thank you!

koobs retitled this revision from New Port: misc/g810-led: Led controller for Logitech G- Keyboards to [NEW] misc/g810-led: Led controller for Logitech G- Keyboards.
koobs edited the summary of this revision. (Show Details)
koobs edited the summary of this revision. (Show Details)
koobs added a subscriber: koobs.

Nice work Alexander. Minor case nit in COMMENT, otherwise looks good

misc/g810-led/Makefile
9

Minor nit: s/Led/LED

This revision is now accepted and ready to land.May 24 2021, 3:02 AM
This revision now requires review to proceed.May 24 2021, 9:28 AM

Looks good, nice work Alexander

This revision is now accepted and ready to land.May 24 2021, 9:33 AM