Differential D29604

pci_user.c: Call bus_translate_resource before mmaping bars
ClosedPublic
Actions

Authored by kd on Apr 6 2021, 2:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 10, 1:14 PM

	Unknown Object (File)
	Sun, Dec 7, 5:49 AM

	Unknown Object (File)
	Sun, Nov 30, 7:41 AM

	Unknown Object (File)
	Fri, Nov 28, 11:05 AM

	Unknown Object (File)
	Sun, Nov 23, 12:36 PM

	Unknown Object (File)
	Fri, Nov 21, 7:37 AM

	Unknown Object (File)
	Fri, Nov 21, 2:54 AM

	Unknown Object (File)
	Wed, Nov 19, 3:12 AM

Subscribers

Details

Reviewers

kib
mw

Commits

rG14721190e829: pci_user: call bus_translate_resource before BAR mmap
rGf2f1ab39c040: pci_user: call bus_translate_resource before BAR mmap

Summary

On some armv8 machines there is no 1:1 mapping between cpu and pci bus BAR base addresses.
When a BAR is allocated in kernel using bus_alloc_resource_any this translation is handled in ofw_pci_activate_resource.
Do the same in pci_user.c by calling bus_translate_resource devmethod. This fixes mmaping BARs to userspace on armada7k and possibly many other platforms.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kd requested review of this revision.Apr 6 2021, 2:11 PM

kd created this revision.

kib accepted this revision.Apr 6 2021, 2:53 PM

This revision is now accepted and ready to land.Apr 6 2021, 2:53 PM

Closed by commit rGf2f1ab39c040: pci_user: call bus_translate_resource before BAR mmap (authored by mw). · Explain WhyApr 6 2021, 3:17 PM

This revision was automatically updated to reflect the committed changes.

mw added a commit: rGf2f1ab39c040: pci_user: call bus_translate_resource before BAR mmap.

mw added a commit: rG14721190e829: pci_user: call bus_translate_resource before BAR mmap.Oct 11 2021, 1:58 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 11 2021, 1:58 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

5 lines

Diff 86905

sys/dev/pci/pci_user.c

Loading...