Details
- Reviewers
gjb wblock - Commits
- rD47063: Document the target helpers introduced in rP391051.
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
The rendered version does not seem to have the new additions yet. Looks okay otherwise.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
---|---|---|
4731 | Working on this. :) |
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
---|---|---|
4660 | This should be Target. The plural is "Target Additions". |
Ah, sorry about that, the workflow is still not perfect, looks like a race condition that needs fixing.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
---|---|---|
4660 | I'm not very happy with the title, but I can't think of anything else. |
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
---|---|---|
4660 | Good question. Need more description of these targets to make a guess. What are these targets? "General-Purpose"? | |
4662 | It's only the first half of a sentence. For any of these targets: And then it ends. Or Phabricator doesn't show it. But it seems to start, show some targets, and then doesn't say anything about them or what they are. |
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
---|---|---|
4660 | Mmmm, well, the ports tree provide targets, like pre-extract, post-configure, post-install, so that you can add things before or after the normal building process of the software, so that it fetches/extracts/patches/builds/... correctly. These helpers are here to help you add to these targets when enabling or disabling options. It's explained in the summary of D2944. | |
4662 | Well, the end of the sentence is the two sub-sections after. |
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
---|---|---|
4660 | ping ? 0:-) |
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
---|---|---|
4734 | <buildtarget> should be usable here now. Please test. |
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
---|---|---|
4660 | "Additional Build Targets"? | |
4662 | The confusion is because it says: For any of these targets: ...list... The following build targets can be used. That is really one sentence, and capitalizing "The" makes it look like a second sentence. Better to split those apart: These <filename>Makefile</filename> targets can accept optional extra build targets: ...list... The additional build targets are listed below. |