Page MenuHomeFreeBSD

Document the target helpers from D2944.
ClosedPublic

Authored by mat on Jun 30 2015, 2:28 PM.

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat updated this revision to Diff 6584.Jun 30 2015, 2:28 PM
mat retitled this revision from to Document the target helpers from D2944..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added reviewers: wblock, gjb.
mat set the repository for this revision to rD FreeBSD doc repository.
wblock edited edge metadata.Jul 2 2015, 2:04 AM

The rendered version does not seem to have the new additions yet. Looks okay otherwise.

en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4731 ↗(On Diff #6584)

Working on this. :)

wblock added inline comments.Jul 2 2015, 2:06 AM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4660 ↗(On Diff #6584)

This should be Target. The plural is "Target Additions".

mat marked an inline comment as done.Jul 2 2015, 11:28 AM
In D2957#58255, @wblock wrote:

The rendered version does not seem to have the new additions yet. Looks okay otherwise.

Ah, sorry about that, the workflow is still not perfect, looks like a race condition that needs fixing.

en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4660 ↗(On Diff #6584)

I'm not very happy with the title, but I can't think of anything else.

mat updated this revision to Diff 6643.Jul 2 2015, 11:40 AM
mat marked an inline comment as done.
mat edited edge metadata.

Fix.

mat updated this revision to Diff 6647.Jul 2 2015, 12:23 PM

rebase

wblock added inline comments.Jul 2 2015, 2:30 PM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4660 ↗(On Diff #6647)

Non-native English speakers often have trouble with the meaning of the word "generic".

4662 ↗(On Diff #6647)

Is there some kind of continuation of this sentence after the list? Seems incomplete.

mat updated this revision to Diff 6654.Jul 2 2015, 10:42 PM

rebase

mat added inline comments.Jul 3 2015, 11:26 AM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4660 ↗(On Diff #6654)

What would you propose ?

4662 ↗(On Diff #6654)

I basically copied the previous section and replaced, variable with target :-)

wblock added inline comments.Jul 4 2015, 12:42 AM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4660 ↗(On Diff #6654)

Good question. Need more description of these targets to make a guess. What are these targets? "General-Purpose"?

4662 ↗(On Diff #6654)

It's only the first half of a sentence.

For any of these targets:
a
b
c

And then it ends. Or Phabricator doesn't show it. But it seems to start, show some targets, and then doesn't say anything about them or what they are.

mat added inline comments.Jul 6 2015, 9:46 AM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4660 ↗(On Diff #6654)

Mmmm, well, the ports tree provide targets, like pre-extract, post-configure, post-install, so that you can add things before or after the normal building process of the software, so that it fetches/extracts/patches/builds/... correctly. These helpers are here to help you add to these targets when enabling or disabling options. It's explained in the summary of D2944.

4662 ↗(On Diff #6654)

Well, the end of the sentence is the two sub-sections after.

mat marked an inline comment as done.Jul 21 2015, 12:51 PM
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4660 ↗(On Diff #6654)

ping ? 0:-)

mat marked 2 inline comments as done.Jul 21 2015, 12:52 PM
mat updated this revision to Diff 7136.Jul 21 2015, 12:53 PM
  • Update.
wblock added inline comments.Jul 21 2015, 3:48 PM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4745 ↗(On Diff #7136)

<buildtarget> should be usable here now. Please test.

mat updated this revision to Diff 7169.Jul 22 2015, 10:41 AM
  • Use buildtarget in title, it works now.
mat marked an inline comment as done.Jul 22 2015, 10:42 AM
wblock added inline comments.Jul 22 2015, 3:10 PM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4671 ↗(On Diff #7169)

"Additional Build Targets"?

4673 ↗(On Diff #7169)

The confusion is because it says:

For any of these targets:

...list...

The following build targets can be used.

That is really one sentence, and capitalizing "The" makes it look like a second sentence. Better to split those apart:

These <filename>Makefile</filename> targets can accept optional extra build targets:

...list...

The additional build targets are listed below.

mat marked 5 inline comments as done.Jul 24 2015, 12:40 PM
This revision was automatically updated to reflect the committed changes.