Avoid a situation where we do not set persist timer after a zero window condition.
ClosedPublic
Actions

Authored by hiren on Jun 29 2015, 5:07 PM.

Details

Reviewers

jhb
jch
gnn

Summary

If you send a 0-length packet, but there is data is the socket buffer,
and neither the rexmt or persist timer is already set, then activate
the persist timer.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

hiren updated this revision to Diff 6555.Jun 29 2015, 5:07 PM

hiren retitled this revision from to Avoid a situation where we do not set persist timer after a zero window condition..

hiren updated this object.

hiren edited the test plan for this revision. (Show Details)

hiren added reviewers: jhb, jch.

hiren added a subscriber: network.

Herald added a subscriber: imp. · View Herald TranscriptJun 29 2015, 5:07 PM

I reviewed this patch as part of:

zero window and persist timer not set
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192599

And look good to me. Thanks again for the detailed report and patch.

jch accepted this revision.Jun 29 2015, 5:14 PM

jch edited edge metadata.

This revision is now accepted and ready to land.Jun 29 2015, 5:14 PM

Only in TCP do we have that many lines of comment for such a few lines of code. I am not complaining.

hiren mentioned this in rS284941: Avoid a situation where we do not set persist timer after a zero window.Jun 29 2015, 9:23 PM

hiren closed this revision.Aug 20 2015, 5:56 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_output.c

24 lines

Diff 6555

View Options

Avoid a situation where we do not set persist timer after a zero window condition.ClosedPublicActions