Page MenuHomeFreeBSD

LinuxKPI: add more linux-specific errno
ClosedPublic

Authored by bz on Tue, Mar 23, 4:49 PM.

Details

Summary

Add ERFKILL and EBADE found in iwlwifi and brcmfmac wireless drivers.

Obtained-from: bz_iwlwifi
Sponsored-by: The FreeBSD Foundation
MFC-after: 2 weeks
Reviewed-by: ...
Differential Revision:

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz requested review of this revision.Tue, Mar 23, 4:49 PM
sys/compat/linuxkpi/common/include/linux/errno.h
64–65

Do the values match some Linux definitions, or are they arbitrary?

This revision is now accepted and ready to land.Tue, Mar 23, 7:40 PM
manu added inline comments.
sys/compat/linuxkpi/common/include/linux/errno.h
64–65

They do not match linux definitions which could cause problems if they are expected to be returned to userland.

sys/compat/linuxkpi/common/include/linux/errno.h
64–65

I'd assume (without looking) that none of the errnos in the 500s is matching Linux. Maybe we should add a comment if my assumption is correct?

If they'd be returned to userland then it'd be a linux binary compat issue only I'd assume as native FreeBSD apps will normally never use those. In my case they currently should not be.

Add a comment above the block of error numbers above 500 to
document expectations as asked by @emaste and clarified by @manu .

This revision now requires review to proceed.Wed, Mar 24, 7:12 PM
bz marked 2 inline comments as done.Wed, Mar 24, 7:13 PM
This revision is now accepted and ready to land.Wed, Mar 24, 7:14 PM
This revision was automatically updated to reflect the committed changes.