Page MenuHomeFreeBSD

Add www/unit-nodejs port, nodejs module for NGINX Unit
Needs ReviewPublic

Authored by osa on Mar 21 2021, 3:26 PM.
Tags
None
Referenced Files
F143329044: D29362.diff
Wed, Jan 28, 11:42 PM
Unknown Object (File)
Sat, Jan 24, 3:03 PM
Unknown Object (File)
Sat, Jan 17, 9:06 AM
Unknown Object (File)
Fri, Jan 16, 1:27 PM
Unknown Object (File)
Sun, Jan 11, 12:45 AM
Unknown Object (File)
Thu, Jan 8, 6:42 PM
Unknown Object (File)
Thu, Jan 8, 11:51 AM
Unknown Object (File)
Thu, Jan 8, 11:08 AM

Details

Reviewers
mat

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37984
Build 34873: arc lint + arc unit

Event Timeline

osa requested review of this revision.Mar 21 2021, 3:26 PM
osa retitled this revision from Add www/unit-nodejs port, nodejs module for NGINX Unit. to Add www/unit-nodejs port, nodejs module for NGINX Unit.Mar 21 2021, 3:37 PM
osa added a reviewer: mat.
otis added inline comments.
www/unit-nodejs/Makefile
6

I'd use one of Magic MASTER_SITES Macros here.

92

commands should not be silenced.

lwhsu added inline comments.
www/unit-nodejs/Makefile
39

I think it's long enough to be put in a separated file.

osa marked 2 inline comments as done.Mar 21 2021, 7:56 PM
osa marked an inline comment as done.Mar 21 2021, 8:22 PM

Fix the warning on stage-qa phase.

Make portlint(8) happier.

Support all NodeJS versions, i.e. 15, 14, 12, 10.