systat: Add SPDX-License-Identifier
AbandonedPublic
Actions

Authored by emaste on Mar 20 2021, 6:22 PM.

Details

Reviewers

imp
mr
mckusick
ota_j.email.ne.jp
emaste

Commits

rG9e16b9530aab: Clean up copyright messages.

Summary

Add SPDX-License-Identifier to files missing

Test Plan

N/A

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38823
Build 35712: arc lint + arc unit

Event Timeline

ota_j.email.ne.jp created this revision.Mar 20 2021, 6:22 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 20 2021, 6:22 PM

ota_j.email.ne.jp requested review of this revision.Mar 20 2021, 6:22 PM

Harbormaster completed remote builds in B37966: Diff 86085.Mar 20 2021, 6:22 PM

imp accepted this revision.Mar 21 2021, 12:27 AM

This revision is now accepted and ready to land.Mar 21 2021, 12:27 AM

Hi,
I get the following during applying the patch:

git arc patch D29354
INFO Base commit is not in local repository; trying to fetch.
Prüfe Patch usr.bin/systat/sysput.c ...
Prüfe Patch usr.bin/systat/proc.c ...
error: usr.bin/systat/proc.c ist nicht im Index
Patch usr.bin/systat/sysput.c sauber angewendet

Patch Failed!
Usage Exception: Unable to apply patch!

Is proc.c in another revision or bug report?

This revision now requires changes to proceed.Apr 21 2021, 6:40 PM

systat: Update to SPDX BSD-2-Clause - I've written zarc.c and sysput.c and University of California hasn't been involved

Harbormaster completed remote builds in B38823: Diff 88023.Apr 23 2021, 4:13 AM

I had mixed with another changeset and caused failures.

I've written sysput.c and zarc.c.
I copied other BSD-2-Coluser to remove "the University" sentences.

We do not add and extra blank line at the end of copyright notices. Do you have a reason for adding it in these two copyright messages?

Fix once more.

Harbormaster completed remote builds in B39113: Diff 88998.May 11 2021, 1:12 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 11 2021, 6:12 AM

Closed by commit rG9e16b9530aab: Clean up copyright messages. (authored by mckusick). · Explain Why

This revision was automatically updated to reflect the committed changes.

mckusick added a commit: rG9e16b9530aab: Clean up copyright messages..

forgot to approve before committing.

This now follows FreeBSD style.

ota_j.email.ne.jp accepted this revision.May 11 2021, 9:55 PM

This change has now been MFC'ed to 12-stable and 13-stable, so can be closed.

It seems Phab will not offer the option to close again :(

Ed, thanks for trying to do the close. Seems like a bug in Phabricator, but not sure to whom to report it. Meanwhile, abandonment seems like the best option.