Differential D29328

Unbreak MSG_CMSG_CLOEXEC
ClosedPublic
Actions

Authored by arichardson on Mar 18 2021, 5:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 28, 5:28 AM

	Unknown Object (File)
	Mon, Jun 22, 4:10 PM

	Unknown Object (File)
	May 27 2026, 6:17 AM

	Unknown Object (File)
	May 25 2026, 3:25 PM

	Unknown Object (File)
	May 21 2026, 6:18 AM

	Unknown Object (File)
	May 12 2026, 6:52 PM

	Unknown Object (File)
	May 6 2026, 3:42 AM

	Unknown Object (File)
	May 5 2026, 3:41 PM

Subscribers

Details

Reviewers

mjg
kib
jilles

Commits

rG7962978754d3: Unbreak MSG_CMSG_CLOEXEC
rG6ceacebdf522: Unbreak MSG_CMSG_CLOEXEC

Summary

MSG_CMSG_CLOEXEC has not been working since 2015 (SVN r284380) because
_finstall expects O_CLOEXEC and not UF_EXCLOSE as the flags argument.
This was probably not noticed because we don't have a test for this flag
so this commit adds one. I found this problem because one of the
libwayland tests was failing.

Fixes: ea31808c3b07 ("fd: move out actual fp installation to _finstall")

Test Plan

Newly added test failed before, passes now.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Mar 18 2021, 5:33 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 18 2021, 5:33 PM

arichardson requested review of this revision.Mar 18 2021, 5:33 PM

Harbormaster completed remote builds in B37917: Diff 85972.Mar 18 2021, 5:34 PM

mjg accepted this revision.Mar 18 2021, 6:00 PM

This revision is now accepted and ready to land.Mar 18 2021, 6:00 PM

kib accepted this revision.Mar 18 2021, 6:10 PM

Closed by commit rG6ceacebdf522: Unbreak MSG_CMSG_CLOEXEC (authored by arichardson). · Explain WhyMar 18 2021, 8:53 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG6ceacebdf522: Unbreak MSG_CMSG_CLOEXEC.

arichardson added a commit: rG7962978754d3: Unbreak MSG_CMSG_CLOEXEC.Apr 10 2021, 1:30 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

tests/

sys/

kern/

unix_passfd_test.c

45 lines

Diff 85998

sys/kern/uipc_usrreq.c

Loading...

tests/sys/kern/unix_passfd_test.c

Loading...