documentation/content/en/books/handbook/mirrors/_index.adoc
395	Maybe "base system source code"?
408	Subversion?
444	do we want to expand `git` here with example URL / directory?
468	Can we put an entry across both columns for the headings ("src", "ports"), or maybe make this something like Web-based repository browser - doc repository
478	Can we give advice on what we mean by "the future" - e.g. after svn is retired, ...?
486	Do we want to mark up `[-b branch]` indicating it is optional?
499	svn.FreeBSD.org?
508	This looks like literal lwdir, do we want to make it more clear that this is a placeholder
555	mirrors
610	For now, we can mention that these will likely change

A few nits and typos I spotted in my first readthrough, plus some questions.

documentation/content/en/books/handbook/mirrors/_index.adoc
408
444	Isn't "local working copy" SVN parlance? I thought with Git it was called a clone instead.
482	Again, SVN vocabulary
486	Isn't there more to it than that? To get the r* numbers imported from SVN? (I'm on the fence with this. On the con side, it may be unneeded complication, on the pro side, sometimes non-contributors need to refer to r* numbers.)
522
555
559
587
632
640
659

vigole.com_outlook.com added a subscriber: vigole.com_outlook.com.Mar 14 2021, 4:15 AM

If I didn't miss anything, now we have certificate installed in /usr/share/certs/trusted Maybe mention installing security/ca_root_nss only is needed on older versions?

vigole.com_outlook.com added inline comments.Mar 14 2021, 9:10 AM

documentation/content/en/books/handbook/mirrors/_index.adoc
399	Maybe: portsnap --> net/gitup

debdrup added a subscriber: debdrup.Mar 14 2021, 11:16 AM

debdrup added inline comments.

documentation/content/en/books/handbook/mirrors/_index.adoc
399	Ports hasn't yet transistioned to git, so this is a bit premature.
486	There's a section below which covers daily usage, where the notes (which store the svn revision IDs) are fetched. I think it would be better to have a single section which describes the flow with explanations, rather than two sections where one has explanations and another has the flow, as this can lead to confusion.

2khramtsov_gmail.com mentioned this in D29234: development(7): mention the Git mirror list in the manual page.Mar 14 2021, 12:31 PM

2khramtsov_gmail.com added a subscriber: 2khramtsov_gmail.com.

rebase and plow in feedback so far.

Harbormaster completed remote builds in B37838: Diff 85746.Mar 14 2021, 9:09 PM

pauamma_gundo.com added inline comments.Mar 14 2021, 9:29 PM

documentation/content/en/books/handbook/mirrors/_index.adoc
440
506
584
726–728	"Older" meaning? (IIRC, it's only 11.4.)

all these look good. Will change.

documentation/content/en/books/handbook/mirrors/_index.adoc
399	This was a conscious choice. portsnap is still the right thing to use.
408	Also, this is only for older systems since Kyle committed the root CAs to base.
444	working tree. And no example. not here, we do just below.
468	Too much of a hassle for this round. Spending a ton of time on this (which it needs to look good, imho), will make the rest of these changes later. I'll do that in a followup to get the rest of the things in .
478	I'm unsure when lwshu plans to retire things, so I can't be super specific... I'll change it to 'sometime after the switch to git is complete' which is better on many levels.
486	No. There's nothing more to it. That's all you need. There's a different chapter that goes into all the details. This is just the basics.
508	Yea, unsure how to do that in asciidoc. Will do something if someone can suggest how to do things inside a literal.
522	This likely should be a link.