Make all .so symlinks relative
ClosedPublic
Actions

Authored by bapt on Jun 27 2015, 1:38 AM.

Details

Reviewers

emaste
imp
adrian

Summary

if SHLIBDIR != LIBDIR then we enforce install to generate a relative symlink.
In that case, add DESTDIR to the path of the target path so install(1) is able
to compute the relative link.

This also allows to remove the now useless _SHLIBDIRPREFIX used to workaround
issues when building cross tools and bootstrap tools

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

bapt updated this revision to Diff 6489.Jun 27 2015, 1:38 AM

bapt retitled this revision from to Make all .so symlinks relative.

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

bapt added reviewers: imp, adrian, emaste.

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJun 27 2015, 1:38 AM

Just tested it - works great.

There are some things left over that aren't relative symlinked:

adrian@hulk:~/work/freebsd/head-embedded/root/mips_ap % find . -type l -exec readlink {} \; | grep ^/
/bin/pkill
/bin/pgrep
/usr/sbin/mailwrapper
/usr/sbin/mailwrapper
/libexec/ld-elf.so.1
/usr/libexec/bsdinstall/partedit
/usr/sbin/mailwrapper
/usr/sbin/mailwrapper
/usr/sbin/mailwrapper
/usr/share/misc/termcap
/usr/sbin/rmt
/usr/sbin/nologin

.. but they can come afterwards!

adrian accepted this revision.Jun 27 2015, 9:35 PM

adrian edited edge metadata.

This revision is now accepted and ready to land.Jun 27 2015, 9:35 PM

I think this will do the right thing in all cases... wonder why we had this kludge in the first place?

imp accepted this revision.Jun 27 2015, 10:45 PM

imp edited edge metadata.