Page MenuHomeFreeBSD
Differential D29139

share/man/man9/pwmbus.9 fix types in arguments
ClosedPublic
Actions

Authored by oskar.holmlund_ohdata.se on Mar 9 2021, 10:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 2:16 PM
Unknown Object (File)
Thu, Nov 14, 2:09 PM
Unknown Object (File)
Wed, Nov 13, 10:57 PM
Unknown Object (File)
Oct 2 2024, 9:50 AM
Unknown Object (File)
Oct 2 2024, 2:06 AM
Unknown Object (File)
Oct 1 2024, 10:10 PM
Unknown Object (File)
Oct 1 2024, 5:18 PM
Unknown Object (File)
Oct 1 2024, 4:20 PM
View All 89 Files
Subscribers
rpokala

Details

Reviewers
manu
lwhsu
rpokala
Group Reviewers
manpages
Commits
rG5c11eddf9578: share/man/man9/pwmbus.9 fix types in arguments
rG7d4a5de84d5e: share/man/man9/pwmbus.9 fix types in arguments
Summary

Fix the types of period and duty in share/man/man9/pwmbus.9 to match the one in sys/dev/pmw/pwmbus.c.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

oskar.holmlund_ohdata.se requested review of this revision.Mar 9 2021, 10:05 AM
oskar.holmlund_ohdata.se created this revision.
oskar.holmlund_ohdata.se mentioned this in D29137: usr.sbin/pwm/pwm add support for flags.
lwhsu added a reviewer: manpages.Mar 9 2021, 11:42 AM
rpokala requested changes to this revision.Mar 10 2021, 3:44 AM
rpokala added a subscriber: rpokala.
rpokala added inline comments.
share/man/man9/pwmbus.9
43

The code in pwmbus.c has u_int for channel for all of these...

45

channel isn't an argument for this function.

This revision now requires changes to proceed.Mar 10 2021, 3:44 AM
oskar.holmlund_ohdata.se updated this revision to Diff 85466.Mar 10 2021, 9:58 AM

pwmbus.9
change type for argument channel and the pointer nchannel (int -> u_int)

pwmbus_if.m:

  • argument name dev -> bus
  • use u_int instead of unsigned int.
oskar.holmlund_ohdata.se marked 2 inline comments as done.Mar 10 2021, 9:59 AM

rpokala: Thank you for your comments.

rpokala accepted this revision.Mar 11 2021, 8:27 AM

LGTM. Remember to bump .Dd when you commit.

This revision is now accepted and ready to land.Mar 11 2021, 8:27 AM
manu accepted this revision.Mar 11 2021, 8:29 AM
Closed by commit rG7d4a5de84d5e: share/man/man9/pwmbus.9 fix types in arguments (authored by oskar.holmlund_ohdata.se, committed by manu). · Explain WhyMar 11 2021, 8:59 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG7d4a5de84d5e: share/man/man9/pwmbus.9 fix types in arguments.
manu added a commit: rG5c11eddf9578: share/man/man9/pwmbus.9 fix types in arguments.Jul 22 2021, 4:40 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
30 lines
sys/
dev/
pwm/
14 lines

Diff 85555

View Options

share/man/man9/pwmbus.9

Loading...
View Options

sys/dev/pwm/pwmbus_if.m

Loading...