Page MenuHomeFreeBSD

link_elf_obj: Process init_array and fini_array
ClosedPublic

Authored by markj on Mar 3 2021, 9:05 PM.

Details

Summary

Reuse the existing logic for .ctors/.dtors.

This is required for KASAN.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.Mar 3 2021, 9:05 PM
markj added inline comments.
sys/kern/link_elf_obj.c
534

I am not sure why .dtors is not handled. I don't have a use for it but can implement it if it seems worthwhile.

In principle it could be that an object contains both .ctors and SHT_INIT_ARRAY sections. I suggest to warn, at least.

BTW, we rely on ld -r correctly merge all sections with the same name+attributes, but for many reasons this might not occur. So I think a warning is due if ctors_addr is non-NULL.

Print a warning if ctors_addr is already non-zero.

This revision is now accepted and ready to land.Mar 3 2021, 10:36 PM