Page MenuHomeFreeBSD

link_elf_obj: Process init_array and fini_array
ClosedPublic

Authored by markj on Mar 3 2021, 9:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 27, 9:45 AM
Unknown Object (File)
Tue, Mar 24, 12:23 AM
Unknown Object (File)
Mon, Mar 23, 9:22 PM
Unknown Object (File)
Mon, Mar 23, 11:52 AM
Unknown Object (File)
Sun, Mar 22, 10:17 PM
Unknown Object (File)
Sat, Mar 21, 6:07 PM
Unknown Object (File)
Thu, Mar 19, 10:47 AM
Unknown Object (File)
Tue, Mar 17, 9:03 AM
Subscribers

Details

Summary

Reuse the existing logic for .ctors/.dtors.

This is required for KASAN.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Mar 3 2021, 9:05 PM
markj added inline comments.
sys/kern/link_elf_obj.c
535

I am not sure why .dtors is not handled. I don't have a use for it but can implement it if it seems worthwhile.

In principle it could be that an object contains both .ctors and SHT_INIT_ARRAY sections. I suggest to warn, at least.

BTW, we rely on ld -r correctly merge all sections with the same name+attributes, but for many reasons this might not occur. So I think a warning is due if ctors_addr is non-NULL.

Print a warning if ctors_addr is already non-zero.

This revision is now accepted and ready to land.Mar 3 2021, 10:36 PM