Page MenuHomeFreeBSD

Remove sv_sigtbl from the arm64 sendsig().
ClosedPublic

Authored by kib on Jun 23 2015, 6:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 2 2024, 5:35 AM
Unknown Object (File)
Sep 27 2024, 2:55 AM
Unknown Object (File)
Sep 26 2024, 1:56 PM
Unknown Object (File)
Sep 25 2024, 7:00 PM
Unknown Object (File)
Sep 22 2024, 11:11 PM
Unknown Object (File)
Sep 22 2024, 11:07 AM
Unknown Object (File)
Sep 19 2024, 2:04 AM
Unknown Object (File)
Sep 17 2024, 11:31 PM
Subscribers

Details

Reviewers
andrew
Summary

sv_sendsig is rather dubious idea. In essence, it was supposed to provide signal number translation table for standard sendsig() function. A fatal flaw is that sendsig() enforces the FreeBSD' ABI signal frame layout, which is wrong for ABI emulators. Since ABI emulators must form their own signal frames, they can easily transalte FreeBSD signal number into the ABI signal number, without exporting it in the sysentvec.

I doubt that arm64 has any ABI emulator at all.

Current plan is to fix misuse of the FreeBSD signal frame in the iBCS2 emulator and remove sv_sigtbl at all.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib retitled this revision from to Remove sv_sigtbl from the arm64 sendsig()..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added a reviewer: andrew.
kib set the repository for this revision to rS FreeBSD src repository - subversion.

Would it pay to add a KASSERT for p->p_sysent->sv_sigtbl == NULL, or is the removal of sv_sigtbl planned for soon enough for this not to matter?

In D2889#56733, @andrew wrote:

Would it pay to add a KASSERT for p->p_sysent->sv_sigtbl == NULL, or is the removal of sv_sigtbl planned for soon enough for this not to matter?

The goal is to remove sv_sigtbl.

How fast it happens, depends on how fast I get an approval to commit the iBCS2 changes.

andrew edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2015, 9:59 AM