Page MenuHomeFreeBSD

Reduce bqlock contention in binsfree
ClosedPublic

Authored by cse_cem_gmail_com on Jun 22 2015, 4:42 PM.

Details

Reviewers
kib
cem
Summary

Only take 'olock' when needed for REMFREE.

Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

cse_cem_gmail_com retitled this revision from to Reduce bqlock contention in binsfree.
cse_cem_gmail_com updated this object.
cse_cem_gmail_com edited the test plan for this revision. (Show Details)
cse_cem_gmail_com added a reviewer: kib.
cse_cem_gmail_com added subscribers: benno, bdrewery.

This looks fine.

sys/kern/vfs_bio.c
996–997

It seems you do not need to evaluate olock if B_REMFREE flag is not set.

999–1001

Move olock calculation there.

Will fix.

sys/kern/vfs_bio.c
996–997

Sure. But it isn't expensive either:

bqlock(int qindex)
{

        if (qindex == QUEUE_DIRTY)
                return (struct mtx *)(&bqdirty);
        return (struct mtx *)(&bqclean);
}
999–1001

Ok.

cse_cem_gmail_com edited edge metadata.

Move olock calculation to only where it is needed.

cem added a reviewer: cem.
This revision is now accepted and ready to land.Jul 9 2015, 10:11 PM