efirt: add hooks for diverging EFI implementations
ClosedPublic
Actions

Authored by royger on Feb 12 2021, 4:02 PM.

Details

Reviewers

kevans
kib
imp

Commits

rG27d3902679cd: efirt: add hooks for diverging EFI implementations

Summary

Introduce a set of hooks for MI EFI public functions, so that a new
implementation can be done. This will be used to implement the Xen PV
EFI interface that's used when running FreeBSD as a Xen dom0 from UEFI
firmware. Also make the efi_status_to_errno non-static since it will
be used to evaluate status return values from the PV interface.

No functional change indented.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

royger created this revision.Feb 12 2021, 4:02 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2021, 4:02 PM

royger requested review of this revision.Feb 12 2021, 4:02 PM

Harbormaster completed remote builds in B36935: Diff 83771.Feb 12 2021, 4:02 PM

For the reference, the user of this new interface is at: https://reviews.freebsd.org/D28621

Seems fine. The log could be a little clearer that FreeBSD needs to implement the EFI interfaces for pvefi, but if you can't make it clearer both the code and commit message are OK. And a comment where suggested would give the reader the proper context for the 'why' which wasn't immediately obvious to me.

sys/sys/efi.h
182–201	Might make sense to add that we either call the real efi firmware, or virtualize it for VMs in some kind of comment here.

This revision is now accepted and ready to land.Feb 12 2021, 5:44 PM

kib added inline comments.Feb 12 2021, 11:51 PM

sys/dev/efidev/efirt.c
568	Should this be const. I prefer to have this structure static, and use const struct efi_ops *active_efi_ops or such for calls, initialized at boot or module load.