Page MenuHomeFreeBSD
Differential D28581

Allows atf scripts to pass qa
ClosedPublic
Actions

Authored by olivier on Feb 10 2021, 10:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 1, 10:22 PM
Unknown Object (File)
Thu, Oct 1, 4:45 PM
Unknown Object (File)
Sat, Sep 19, 5:19 PM
Unknown Object (File)
Sat, Sep 19, 5:10 PM
Unknown Object (File)
Sat, Sep 19, 5:07 PM
Unknown Object (File)
Sat, Sep 19, 10:17 AM
Unknown Object (File)
Sep 10 2026, 4:59 PM
Unknown Object (File)
Sep 8 2026, 8:13 PM
View All Files
Subscribers
lwhsu
rene

Details

Reviewers
lwhsu
rene
Group Reviewers
portmgr
O5: Ports Framework
Commits
rP567848: Allows atf scripts to pass qa
Summary

Mk/Scripts/qa.sh doesn't allow ATF-shell script shebang (/usr/libexec/atf-sh), but they are valid.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olivier requested review of this revision.Feb 10 2021, 10:30 PM
olivier created this revision.
lwhsu added a subscriber: lwhsu.Feb 11 2021, 11:58 AM
rene added a subscriber: rene.Feb 14 2021, 3:44 PM

Should be fine AFAICT.

lwhsu accepted this revision.Feb 14 2021, 4:02 PM

portmgr : this looks good and trivial, Can we have this approved soon?

This revision is now accepted and ready to land.Feb 14 2021, 4:02 PM
rene added a comment.Feb 14 2021, 4:09 PM
In D28581#641503, @lwhsu wrote:

portmgr : this looks good and trivial, Can we have this approved soon?

I don't expect anyone to object, feel free to remind me later this week.

olivier added a comment.Feb 26 2021, 10:32 PM
In D28581#641508, @rene wrote:
In D28581#641503, @lwhsu wrote:

portmgr : this looks good and trivial, Can we have this approved soon?

I don't expect anyone to object, feel free to remind me later this week.

Hi @rene ,

Here is a gentle reminder :-)

rene accepted this revision.Mar 6 2021, 8:43 PM

Sorry for not seeing the reminder earlier ...

Closed by commit rP567848: Allows atf scripts to pass qa (authored by olivier). · Explain WhyMar 8 2021, 2:11 PM
This revision was automatically updated to reflect the committed changes.
olivier added a commit: rP567848: Allows atf scripts to pass qa.
Owners added a reviewer: O5: Ports Framework.Mar 8 2021, 2:11 PM

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
Scripts/
1 lineO5: Ports Framework

Diff 85328

View Options

head/Mk/Scripts/qa.sh

Loading...