Allows atf scripts to pass qa
ClosedPublic
Actions

Authored by olivier on Feb 10 2021, 10:30 PM.

Details

Reviewers

lwhsu
rene

Group Reviewers

portmgr
O5: Ports Framework	(Owns No Changed Paths)

Commits

rP567848: Allows atf scripts to pass qa

Summary

Mk/Scripts/qa.sh doesn't allow ATF-shell script shebang (/usr/libexec/atf-sh), but they are valid.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

olivier requested review of this revision.Feb 10 2021, 10:30 PM

olivier created this revision.

lwhsu added a subscriber: lwhsu.Feb 11 2021, 11:58 AM

Should be fine AFAICT.

portmgr : this looks good and trivial, Can we have this approved soon?

This revision is now accepted and ready to land.Feb 14 2021, 4:02 PM

In D28581#641503, @lwhsu wrote:

portmgr : this looks good and trivial, Can we have this approved soon?

I don't expect anyone to object, feel free to remind me later this week.

In D28581#641508, @rene wrote:

In D28581#641503, @lwhsu wrote:

portmgr : this looks good and trivial, Can we have this approved soon?

I don't expect anyone to object, feel free to remind me later this week.

Hi @rene ,

Here is a gentle reminder :-)

Sorry for not seeing the reminder earlier ...

Closed by commit rP567848: Allows atf scripts to pass qa (authored by olivier). · Explain WhyMar 8 2021, 2:11 PM

This revision was automatically updated to reflect the committed changes.

olivier added a commit: rP567848: Allows atf scripts to pass qa.

Owners added a reviewer: O5: Ports Framework.Mar 8 2021, 2:11 PM

Revision Contents
Changeset List

Path

Size

Mk/

Scripts/

qa.sh

1 line

Diff 83666

View Options

Allows atf scripts to pass qaClosedPublicActions