Page MenuHomeFreeBSD
Differential D28509

grep: Fix an incorrect description of the -C flag
ClosedPublic
Actions

Authored by 0mp on Feb 5 2021, 6:40 PM.
Tags
None
Referenced Files
F136120191: D28509.id87632.diff
Sat, Nov 15, 10:50 PM
Unknown Object (File)
Sat, Nov 15, 8:38 AM
Unknown Object (File)
Fri, Nov 7, 2:35 PM
Unknown Object (File)
Tue, Nov 4, 3:36 PM
Unknown Object (File)
Tue, Nov 4, 3:35 PM
Unknown Object (File)
Tue, Nov 4, 3:30 PM
Unknown Object (File)
Tue, Nov 4, 3:25 PM
Unknown Object (File)
Tue, Oct 28, 8:28 PM
View All Files
Subscribers
imp
yuripv

Details

Reviewers
kevans
yuripv
Group Reviewers
manpages
Commits
rG90146cfa3180: grep: Fix an incorrect description of the -C flag
rG5a1da25da26b: grep: Fix an incorrect description of the -C flag
rGbe6b8b7a3a18: grep: Fix an incorrect description of the -C flag
Summary

It seems that the number of lines is no longer an optional parameter to
the -C flag. Document it accordingly.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Feb 5 2021, 6:40 PM
Herald added a reviewer: manpages. · View Herald TranscriptFeb 5 2021, 6:40 PM
Herald added a subscriber: imp. · View Herald Transcript
0mp requested review of this revision.Feb 5 2021, 6:40 PM
Harbormaster completed remote builds in B36743: Diff 83438.Feb 5 2021, 6:41 PM
yuripv added a subscriber: yuripv.Feb 5 2021, 9:26 PM
yuripv added inline comments.
usr.bin/grep/grep.1
126
yuripv added inline comments.Feb 5 2021, 9:30 PM
usr.bin/grep/grep.1
126

Actually, nevermind that, it seems the entire man page has = as part of option name, so let's keep it consistent.

yuripv accepted this revision as: yuripv.Feb 5 2021, 9:35 PM

Looks like usage message needs to be updated as well.

This revision is now accepted and ready to land.Feb 5 2021, 9:35 PM
Closed by commit rGbe6b8b7a3a18: grep: Fix an incorrect description of the -C flag (authored by 0mp). · Explain WhyApr 17 2021, 8:37 PM
This revision was automatically updated to reflect the committed changes.
0mp marked an inline comment as done.
0mp added a commit: rGbe6b8b7a3a18: grep: Fix an incorrect description of the -C flag.
0mp added a comment.Apr 17 2021, 8:46 PM

Thanks, @yuripv!

0mp added a commit: rG5a1da25da26b: grep: Fix an incorrect description of the -C flag.Aug 15 2021, 9:04 PM
0mp added a commit: rG90146cfa3180: grep: Fix an incorrect description of the -C flag.Aug 15 2021, 9:16 PM

Revision Contents
Changeset List

PathSize
usr.bin/
grep/
21 lines
4 lines

Diff 87632

View Options

usr.bin/grep/grep.1

Loading...
View Options

usr.bin/grep/grep.c

Loading...