Page MenuHomeFreeBSD

Add PD_KILL option to prison_deref()
ClosedPublic

Authored by jamie on Wed, Feb 3, 9:43 PM.

Details

Summary

Add the PD_KILL flag that instruction prison_deref() to take steps to actively kill a prison, namely clearing its PR_PERSIST flag and killing any attached processes.

This replaces a similar loop in sys_jail_remove(), bringing the operation under the same single hold on allprison_lock that it already has. It also replaces a bit of one-off code in kern_jail_set() to handle the destruction of almost-finished prisons.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jamie requested review of this revision.Wed, Feb 3, 9:43 PM
jamie created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Feb 22, 8:28 PM
This revision was automatically updated to reflect the committed changes.

After this commit running cd /usr/tests/lib/libc/sys && kyua test cpuset_test renders the entire system unusable (and in Jenkins it's triggering a kernel panic)

Sorry I took so long - I confused your note that it should be reverted with a note that it *had been* reverted.