Page MenuHomeFreeBSD

WITH_OFED build option: fix
ClosedPublic

Authored by kib on Tue, Feb 2, 1:36 PM.

Details

Summary

Userspace has OFED build enabled for quite some time, but kernel modules were not. This is useless config because any userspace IB code requires kernel support. So enable modules build by default.

Move WITH_OFED to WITHOUT_OFED since defaults are now enabled.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib requested review of this revision.Tue, Feb 2, 1:36 PM
kib created this revision.
This revision is now accepted and ready to land.Tue, Feb 2, 2:37 PM

I think we're slightly inclined towards leaving WITH_OFED in-tree even if it's the default, but not a solid objection.

LGTM, one little nit on the option description

tools/build/options/WITHOUT_OFED
2

In our conventional WITH/WITHOUT style this would be "Set to disable the build of the"
IMO these descriptions are very redundant; the description of the option is clearly the action taken when the option is set, so I think just "Do not build the" is sufficient.

This revision was automatically updated to reflect the committed changes.