Page MenuHomeFreeBSD

WITH_OFED build option: fix
ClosedPublic

Authored by kib on Feb 2 2021, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 2:31 PM
Unknown Object (File)
Thu, Mar 7, 5:53 PM
Unknown Object (File)
Jan 24 2024, 8:27 AM
Unknown Object (File)
Dec 20 2023, 6:10 AM
Unknown Object (File)
Dec 14 2023, 8:13 PM
Unknown Object (File)
Dec 3 2023, 10:46 PM
Unknown Object (File)
Dec 2 2023, 12:20 AM
Unknown Object (File)
Sep 21 2023, 10:14 PM

Details

Summary

Userspace has OFED build enabled for quite some time, but kernel modules were not. This is useless config because any userspace IB code requires kernel support. So enable modules build by default.

Move WITH_OFED to WITHOUT_OFED since defaults are now enabled.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Feb 2 2021, 1:36 PM
kib created this revision.
This revision is now accepted and ready to land.Feb 2 2021, 2:37 PM

I think we're slightly inclined towards leaving WITH_OFED in-tree even if it's the default, but not a solid objection.

LGTM, one little nit on the option description

tools/build/options/WITHOUT_OFED
2

In our conventional WITH/WITHOUT style this would be "Set to disable the build of the"
IMO these descriptions are very redundant; the description of the option is clearly the action taken when the option is set, so I think just "Do not build the" is sufficient.

This revision was automatically updated to reflect the committed changes.